Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gorename: TestGeneratedFiles failing on linux-amd64-nocgo #21055

Closed
broady opened this issue Jul 17, 2017 · 3 comments
Closed

x/tools/cmd/gorename: TestGeneratedFiles failing on linux-amd64-nocgo #21055

broady opened this issue Jul 17, 2017 · 3 comments
Labels
FrozenDueToAge OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.9

Comments

@broady
Copy link
Contributor

broady commented Jul 17, 2017 •
edited

Only failing on nocgo, but failing consistently.

Latest log: https://build.golang.org/log/109ba9ba40b4a45b4e59191e5ddd6f004c607a9a

--- FAIL: TestGeneratedFiles (8.30s)
	gorename_test.go:293: 1: -from "\"mytest\"::f" -to "g": command succeeded unexpectedly, output: Renamed 1 occurrence in 1 file in 1 package.
	gorename_test.go:280: 2: -from "\"mytest\"::f" -to "g": unexpected command output: gorename: no object "f" declared in package "mytest"
		 (want: gorename: refusing to modify generated file containing DO NOT EDIT marker:)
	gorename_test.go:280: 3: -from "mytest/0.go::f" -to "g": unexpected command output: gorename: file /tmp/gorename-regtest-602097193/src/mytest/0.go was not part of the loaded program
		 (want: gorename: refusing to modify generated file containing DO NOT EDIT marker:)
	gorename_test.go:280: 4: -offset "main/0.go:#78" -to "bar": unexpected command output: gorename: file /tmp/gorename-regtest-602097193/src/main/0.go was not part of the loaded program
		 (want: cannot rename identifiers in generated file containing DO NOT EDIT marker:)
	gorename_test.go:293: 5: -from "\"test\"::Foo" -to "Bar": command succeeded unexpectedly, output: Renamed 1 occurrence in 1 file in 1 package.
	gorename_test.go:293: 7: -from "\"mytest\"::f" -to "g": command succeeded unexpectedly, output: Renamed 1 occurrence in 1 file in 1 package.

Potentially blocking: #11811 for Go 1.9
@broady broady added this to the Go1.9 milestone Jul 17, 2017
@broady broady added OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure. labels Jul 17, 2017
@broady
Copy link
Contributor Author

broady commented Jul 17, 2017

Caused by http://golang.org/cl/45930

@broady
Copy link
Contributor Author

broady commented Jul 17, 2017

Makes sense. The test is for cgo files and gorename. @mdempsky is disabling the test.

@gopherbot
Copy link

CL https://golang.org/cl/49390 mentions this issue.

@mikioh mikioh changed the title tools: TestGeneratedFiles failing on linux-amd64-nocgo x/tools/cmd/gorename: TestGeneratedFiles failing on linux-amd64-nocgo Jul 21, 2017
@golang golang locked and limited conversation to collaborators Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@broady @mdempsky @gopherbot