Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: unaligned stores to global variables on s390x (causes SIGILL or relocation error) #21048

Closed
mundaym opened this issue Jul 17, 2017 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mundaym
Copy link
Member

mundaym commented Jul 17, 2017

What version of Go are you using (go version)?

go1.9beta2 (also present in go1.8.3)

What operating system and processor architecture are you using (go env)?

linux/s390x

What did you do?

package main

type T struct {
	a [1]byte
	b [2]byte
}

var x T

//go:noinline
func newT() T {
	return T{[1]byte{1}, [2]byte{1,2}}
}

func main() {
	x.b = newT().b
}

(https://play.golang.org/p/jXSguFs4Hk)

What did you expect to see?

Successful execution.

What did you see instead?

main.main: main.x+1054942 is not 2-byte aligned

While not strictly a regression from the last release, this bug does cause the docker tests to fail when using go1.9beta2. I have a somewhat ugly fix, will send a CL shortly.

@mundaym mundaym added this to the Go1.9 milestone Jul 17, 2017
@mundaym mundaym self-assigned this Jul 17, 2017
@gopherbot
Copy link

CL https://golang.org/cl/49250 mentions this issue.

@bradfitz
Copy link
Contributor

If this was present in Go 1.8.x, it's not a candidate for holding up Go 1.9. Sorry. But if you get a safe fix out in the next 24-48 hours, maybe, depending on reviewer feedback.

We're already a couple weeks overdue releasing the Go 1.9rc1 due to other issues.

@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.9 Jul 18, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 18, 2017
@golang golang locked and limited conversation to collaborators Jul 19, 2018
@rsc rsc unassigned mundaym Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants