You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to run the go-contrib-init command while my Go environment was in a half-setup state. I did this by simply unsetting GOROOT in my shell, and then executing the command.
What did you expect to see?
I expected the command to exit, indicating that it failed to install git-codereview.
What did you see instead?
Error running go get golang.org/x/review/git-codereview: exit status 1
Installed git-codereview (ran `go get golang.org/x/review/git-codereview`)
All good. Happy hacking!
Remember to squash your revised commits and preserve the magic Change-Id lines.
Next steps: https://golang.org/doc/contribute.html#commit_changes
We are checking the error returned by running that command, but we don't seem to exit if we fail to install the git-codereview package. Instead we print the error indicating it failed, but then continue operating as-if that didn't happen (including a log line indicating it succeeded):
If this fix seems appropriate, I'd be happy to try and make this my first contribution to Go/Go tools.
bradfitz
changed the title
go-contrib-init does not exit if git-codereview install fails
x/tools/cmd/go-contrib-init: does not exit if git-codereview install fails
Jul 16, 2017
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.8.3 darwin/amd64
What operating system and processor architecture are you using (
go env
)?What did you do?
I tried to run the
go-contrib-init
command while my Go environment was in a half-setup state. I did this by simply unsettingGOROOT
in my shell, and then executing the command.What did you expect to see?
I expected the command to exit, indicating that it failed to install
git-codereview
.What did you see instead?
We are checking the error returned by running that command, but we don't seem to exit if we fail to install the
git-codereview
package. Instead we print the error indicating it failed, but then continue operating as-if that didn't happen (including a log line indicating it succeeded):The text was updated successfully, but these errors were encountered: