-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/cmd/git-codereview: fails if .git/hooks is not a directory #21028
Labels
Milestone
Comments
Ah good to know |
(if anyone in the room at Gophercon wants to work on this one - I'm happy to help!) |
If nobody from GopherCon wants to work on it, I would want to try this one as well |
@xmudrii Did you still want to try this one? |
Yes, I'm just waiting @kevinburke to confirm it's free (I actually went to sleep).
If he wants to give few hints before I start, feel free to do. :)
|
I don't know of anyone currently working on this, sorry
On Sun, Jul 16, 2017 at 01:46 Marko Mudrinić ***@***.***> wrote:
Yes, I'm just waiting @kevinburke to confirm it's free (I actually went
to sleep).
If he wants to give few hints before I start, feel free to do. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21028 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOSI7harrdlO9ehSm02tUD8B415hSzJks5sOb_OgaJpZM4OZHPr>
.
--
…--
Kevin Burke
925.271.7005 | kev.inburke.com
|
CL https://golang.org/cl/49070 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On some versions of Git I think "git init" does not create .git/hooks, so .git exists but .git/hooks doesn't and the tool fails.
git-codereview should create
.git/hooks
if it does not exist before trying to write.git/hooks/commit-msg
The text was updated successfully, but these errors were encountered: