Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/git-codereview: fails if .git/hooks is not a directory #21028

Closed
kevinburke opened this issue Jul 15, 2017 · 7 comments
Closed

x/tools/cmd/git-codereview: fails if .git/hooks is not a directory #21028

kevinburke opened this issue Jul 15, 2017 · 7 comments

Comments

@kevinburke
Copy link
Contributor

On some versions of Git I think "git init" does not create .git/hooks, so .git exists but .git/hooks doesn't and the tool fails.

git-codereview should create .git/hooks if it does not exist before trying to write .git/hooks/commit-msg

@gopherbot gopherbot added this to the Unreleased milestone Jul 15, 2017
@jessfraz
Copy link
Contributor

Ah good to know

@kevinburke
Copy link
Contributor Author

(if anyone in the room at Gophercon wants to work on this one - I'm happy to help!)

@xmudrii
Copy link
Contributor

xmudrii commented Jul 15, 2017

If nobody from GopherCon wants to work on it, I would want to try this one as well

@grepory
Copy link
Contributor

grepory commented Jul 16, 2017

@xmudrii Did you still want to try this one?

@xmudrii
Copy link
Contributor

xmudrii commented Jul 16, 2017 via email

@kevinburke
Copy link
Contributor Author

kevinburke commented Jul 16, 2017 via email

@gopherbot
Copy link

CL https://golang.org/cl/49070 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants