Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/go-contrib-init: tool does not recognize .googlesource.com config #21019

Closed
dlsniper opened this issue Jul 15, 2017 · 5 comments
Closed

Comments

@dlsniper
Copy link
Contributor

What version of Go are you using (go version)?

Go 1.9beta2

What operating system and processor architecture are you using (go env)?

Windows 10

What did you do?

go get golang.org/x/tools/cmd/go-contrib-init

go-contrib-init

What did you expect to see?

All good. Happy hacking!
Remember to squash your revised commits and preserve the magic Change-Id lines.
Next steps: https://golang.org/doc/contribute.html#commit_changes

What did you see instead?

Your .gitcookies file isn't configured.
Next steps:
  * Submit a CLA (https://golang.org/doc/contribute.html#cla) if not done
  * Go to https://go.googlesource.com/ and click "Generate Password" at the top,
    then follow instructions.
  * Run go-contrib-init again.

This seems to be caused by the fact that I already have a line in the configuration containing this:

.googlesource.com       TRUE    /       TRUE    <hidden>      o       git-florinpatan.gmail.com=<hidden>
@bradfitz
Copy link
Contributor

Wasn't this already fixed by https://go-review.googlesource.com/c/48230/ ?

Are you running an old version?

@bradfitz bradfitz changed the title go-contrib-init: tool does not recognize .googlesource.com config x/tools/cmd/go-contrib-init: tool does not recognize .googlesource.com config Jul 15, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jul 15, 2017
@bradfitz
Copy link
Contributor

/cc @kevinburke

@dlsniper
Copy link
Contributor Author

I literally just go getted the tool for the workshop so no, it's not fixed yet I guess. sorry.

@bradfitz
Copy link
Contributor

@dlsniper, but you probably had an old x/tools on disk already from a different x/tool package.

Use go get -u or tell me what git revision of x/tools you have currently.

@dlsniper
Copy link
Contributor Author

I've fixed with go get -u, thank you.

@golang golang locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants