time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969

Dieterbe · 2017-07-10T10:02:57Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go version devel +be855e3f28 Mon Jun 19 23:26:32 2017 +0000 linux/amd64

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/dieter/go"
GORACE=""
GOROOT="/home/dieter/code/go"
GOTOOLDIR="/home/dieter/code/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/tmp/dieter/go-build409613068=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="0"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

> cat main.go
package main

import (
	"fmt"
	"time"
)

func main() {
	tz, err := time.LoadLocation("America/New_York")
	fmt.Printf("New_York %q %q\n", tz, err)
	tz, err = time.LoadLocation("America/New_Yaark")
	fmt.Printf("New_Yaark %q %q\n", tz, err)
}
> cat Dockerfile
FROM alpine
RUN apk add -U tzdata
COPY main /usr/bin/
ENTRYPOINT ["/usr/bin/main"]

go build -o main
docker build .
docker run ea1f31431e4d

What did you expect to see?

New_York "America/New_York" %!q(<nil>)
New_Yaark "UTC" "can't find timezone America/New_Yaark or something"

What did you see instead?

New_York "America/New_York" %!q(<nil>)
New_Yaark "UTC" "open /home/dieter/code/go/lib/time/zoneinfo.zip: no such file or directory"

note that when I run it on my host which does have a zoneinfo.zip I get:

go run main.go
New_York "America/New_York" %!q(<nil>)
New_Yaark "UTC" "cannot find America/New_Yaark in zip file /home/dieter/code/go/lib/time/zoneinfo.zip"

The text was updated successfully, but these errors were encountered:

bradfitz · 2017-07-10T16:26:15Z

Not a regression from Go 1.8 (or any other prior release), so targeting Go 1.10 for consideration.

I don't think it's a good idea to get rid of the part of the error message that says where it was looking to find the answer (which zip file path). You want it to say both things? Failed to find New_Yaark and also the zip file path?

Dieterbe · 2017-07-10T16:58:05Z

i'm not sure TBH. to be clear, is it perfectly normal to have situations where only a few timezones are installed, and where it can only know for sure that a tz doesn't exist if it can check against a zoneinfo.zip file?

ALTree · 2017-07-11T07:47:43Z

@Dieterbe the alternative would be to embed the whole IANA Time Zone database in the binary(?)

I agree we could try to print a better error, though (even if the current one is technically correct).

bradfitz · 2017-07-11T18:37:35Z

@ALTree, some discussion of that is in #20629 (comment).

Dieterbe · 2017-07-11T19:12:05Z

can somebody answer:

to be clear, is it perfectly normal to have situations where only a few timezones are installed, and where it can only know for sure that a tz doesn't exist if it can check against a zoneinfo.zip file?

(i hope that question did not come across snarky or sarcastic. I just need clarity on that before I can think of suggestions for improvement)

bradfitz · 2017-07-11T19:30:10Z

@Dieterbe, oh, I see what you're suggesting now. That if, say, /usr/share/zoneinfo exists on disk and is not empty, that it's the only source of truth and that the zip file shouldn't be used as a backup (and thus the error message of its non-existence would never occur).

That's a possibility. I don't believe the intent of the current code is to blend two sources of information (zoneinfo dir and zip), but just to try the zip if the file on disk doesn't exist. IIRC, currently the code just tries to open a single file under /usr/share/zoneinfo and doesn't try to determine whether sibling files exist.

agnivade · 2018-06-30T19:52:44Z

Analysis: The code directly checks for a file under /usr/share/zoneinfo without checking for the directory. And it only accepts a non syscall.ENOENT error as a valid error to hold in the error variable as it iterates through the list of zoneSources. That is the reason why the error where it was unable to access /usr/share/zoneinfo/<file> was getting eaten up.

So we need to check for the existence of a zoneinfo dir first, and then check for the file inside the dir if it exists and return a similar non ENOENT error ("cannot find <file> in <dir>") like others.

Only thing is, I will need to copy over a minimal implementation of syscall.Stat (to check for dir existence) to prevent dependency on os package. Luckily, for plan9 and windows, the .zip file is the only zoneSource so nothing to do over there.

Will send a CL.

gopherbot · 2018-07-01T04:34:51Z

Change https://golang.org/cl/121877 mentions this issue: time: improve error message for LoadLocation

gopherbot · 2018-09-14T22:13:19Z

Change https://golang.org/cl/135416 mentions this issue: time: return ENOENT from androidLoadTzinfoFromTzdata if zone not found

This makes Android consistent with the change in CL 121877. Updates #20969 Change-Id: I1f114556fd1d4654c8e4e6a59513bddd5dc3d1a0 Reviewed-on: https://go-review.googlesource.com/135416 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Elias Naur <elias.naur@gmail.com>

gopherbot · 2018-12-21T14:55:42Z

Change https://golang.org/cl/155538 mentions this issue: time: Return ENOENT if a zoneinfo zip file is not found.

Updates #20969 Change-Id: Ibcf0bf932d5b1de67c22c63dd8514ed7a5d198fb Reviewed-on: https://go-review.googlesource.com/c/155538 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>

govardhanpagidi · 2019-07-20T00:07:28Z

May I know what is the fix for this issue?

I ran into the same issue, go runtime fails to convert time if the timezone is "Asia/kolkata" but works with "Asia/Calcutta"

it runs of my local machine(go version 1.11.4 , Ubuntu 18.X) but not on server (Ubuntu 16.x).

I appreciate your help !!

ianlancetaylor · 2019-07-20T00:30:46Z

@pagidi This issue was closed months ago. For help with Go, please see https://golang.org/wiki/Questions.

On Ubuntu timezone information comes from files in the /usr/share/zoneinfo directory. So if a timezone works on one system but not another, it means that the two systems have different zoneinfo files.

tsuz · 2019-08-22T17:04:28Z

@pagidi

ADD https://github.com/golang/go/raw/master/lib/time/zoneinfo.zip /usr/local/go/lib/time/zoneinfo.zip

is what made it work for me full gist

govardhanpagidi · 2019-09-09T04:56:35Z

Thanks @tsuz

But My problem seems different.
It works in my development machine since it has go runtime
I don't have go run time in the server (it runs as .deb executable), but the go application expects zoneinfo file in the location /usr/local/go/lib/time/zoneinfo.zip

Is there way, we can give path in the Go program to look for the zoneinfo.zip???

agnivade · 2019-09-09T06:15:20Z

Please look into the documentation - https://golang.org/pkg/time/#LoadLocation.

LoadLocation looks in the directory or uncompressed zip file named by the ZONEINFO environment variable, if any, then looks in known installation locations on Unix systems, and finally looks in $GOROOT/lib/time/zoneinfo.zip.

I would suggest to update the zone information on your remote server. If that does not work, use the ZONEINFO variable.

In future, for Go related questions please use the forums in https://golang.org/wiki/Questions. Closed issues are not monitored. Thanks.

govardhanpagidi · 2019-09-09T09:28:53Z

Thanks for the help! @agnivade

Though I have used ZONEINFO variable it didn't work, am I missing something here?

$ locate zoneinfo
/usr/share/zoneinfo/right/Asia/Brunei
/usr/share/zoneinfo/right/Asia/Calcutta
/usr/share/zoneinfo/right/Asia/Chita
/usr/share/zoneinfo/right/Asia/Choibalsan
/usr/share/zoneinfo/right/Asia/Chongqing
/usr/share/zoneinfo/right/Asia/Kolkata

it means zoneinfo is located in user/share/zoneinfo/

$export ZONEINFO=/usr/share/zoneinfo/

Still I see application throws below Error.
cannot find "Asia/Kolkata" in zip file /usr/local/go/lib/time/zoneinfo.zip

mvrhov · 2019-09-09T13:13:38Z

Because you use the wrong directory in your export
$export ZONEINFO=/usr/share/zoneinfo/right

bradfitz changed the title ~~misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existant timezone~~ time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone Jul 10, 2017

bradfitz added the NeedsDecision label Jul 10, 2017

bradfitz added this to the Go1.10 milestone Jul 10, 2017

janetkuo mentioned this issue Aug 21, 2017

Add timezone to CronJob kubernetes/kubernetes#47266

Closed

leighmcculloch mentioned this issue Nov 6, 2017

time: LoadLocation doesn't work on windows if Go is not installed #21881

Closed

rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017

ianlancetaylor added help wanted NeedsFix labels Jun 29, 2018

ianlancetaylor modified the milestones: Go1.11, Unplanned Jun 29, 2018

gopherbot removed the NeedsDecision label Jun 29, 2018

agnivade self-assigned this Jun 30, 2018

lathama mentioned this issue Jul 10, 2018

Go Timezone file? GoogleContainerTools/distroless#205

Closed

gopherbot closed this as completed in 7df585d Sep 14, 2018

ianlancetaylor mentioned this issue Sep 11, 2019

time: cannot find zone in zip file /usr/local/go/lib/time/zoneinfo.zip #34188

Closed

golang locked and limited conversation to collaborators Sep 8, 2020

gopherbot added the FrozenDueToAge label Sep 8, 2020

rsc unassigned agnivade Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969

time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969

Dieterbe commented Jul 10, 2017 •

edited

Loading

bradfitz commented Jul 10, 2017

Dieterbe commented Jul 10, 2017

ALTree commented Jul 11, 2017 •

edited

Loading

bradfitz commented Jul 11, 2017

Dieterbe commented Jul 11, 2017

bradfitz commented Jul 11, 2017

agnivade commented Jun 30, 2018

gopherbot commented Jul 1, 2018

gopherbot commented Sep 14, 2018

gopherbot commented Dec 21, 2018

govardhanpagidi commented Jul 20, 2019 •

edited

Loading

ianlancetaylor commented Jul 20, 2019

tsuz commented Aug 22, 2019

govardhanpagidi commented Sep 9, 2019

agnivade commented Sep 9, 2019

govardhanpagidi commented Sep 9, 2019

mvrhov commented Sep 9, 2019

time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969

time: misleading "zoneinfo.zip: no such file or directory" error when trying to load non-existent timezone #20969

Comments

Dieterbe commented Jul 10, 2017 • edited Loading

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

bradfitz commented Jul 10, 2017

Dieterbe commented Jul 10, 2017

ALTree commented Jul 11, 2017 • edited Loading

bradfitz commented Jul 11, 2017

Dieterbe commented Jul 11, 2017

bradfitz commented Jul 11, 2017

agnivade commented Jun 30, 2018

gopherbot commented Jul 1, 2018

gopherbot commented Sep 14, 2018

gopherbot commented Dec 21, 2018

govardhanpagidi commented Jul 20, 2019 • edited Loading

ianlancetaylor commented Jul 20, 2019

tsuz commented Aug 22, 2019

govardhanpagidi commented Sep 9, 2019

agnivade commented Sep 9, 2019

govardhanpagidi commented Sep 9, 2019

mvrhov commented Sep 9, 2019

Dieterbe commented Jul 10, 2017 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

ALTree commented Jul 11, 2017 •

edited

Loading

govardhanpagidi commented Jul 20, 2019 •

edited

Loading