-
Notifications
You must be signed in to change notification settings - Fork 18k
x/build/cmd/coordinator: use --no-cache on docker build commands #20936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd really rather not use --no-cache. The speed is nice. I'd rather fix it by specifying the exact hash of all deps, including transitive ones. |
How about if I make it an optional variable to be passed in? Default w/o --no-cache param ... To force --no-cache param ... Wdyt? |
I do not want a In the Gerrit CL you wrote:
But I think there is a correct approach. We can ask Go to give us the transitive list of deps ( I'll write a little tool. |
Fair enough.
What I meant to say is that if we use the current approach of manually doing a go get of only a few packages and reset at the repo for some, it becomes arbitrary on which packages you choose to pin vs not. Agree that it requires a tool to pin all dependencies down. |
Closing this as it's better to use a tool for version pinning and not having to switch between cache and no cache. |
FTR, little tool was in https://go-review.googlesource.com/c/47971/ |
This is related to issue #20747 . I think @bradfitz is unable to reproduce the issue due to docker builds using cache. Use --no-cache to guarantee that steps are done fresh.
I think we may need to do this for other binaries as well.
The text was updated successfully, but these errors were encountered: