Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/internal/gccgoimporter: TestInstallationImporter FAIL due to missing (obsolete?) old/regexp and old/template #20932

Closed
anthonyfok opened this issue Jul 6, 2017 · 1 comment
Milestone

Comments

@anthonyfok
Copy link

While running go test -v ./... on golang.org/x/tools using gccgo (in my attempt to solve https://bugs.debian.org/866710), I noticed a new error that came up recently with TestInstallationImporter in x/tools/go/internal/gccgoimporter.

It looks like old/regexp and old/template are finally removed recently, but the relevant x/tools test is not yet updated to reflect the removal. (I haven't been following Golang development closely, so please excuse me if my hypothesis is totally wrong.)

I do know that you use Gerrit for code review, but I have yet to learn how to use it and don't have free time today, so I am taking the easy way out of just filing a GitHub issue today, and letting you handle the rest. 😉 Anyhow, I suppose a fix would look something like this:

--- golang-go.tools.orig/go/internal/gccgoimporter/gccgoinstallation_test.go	2017-07-06 09:45:20.000000000 +0000
+++ golang-go.tools/go/internal/gccgoimporter/gccgoinstallation_test.go	2017-07-06 19:35:02.250004340 +0000
@@ -116,8 +116,6 @@
 	"net/smtp",
 	"net/textproto",
 	"net/url",
-	"old/regexp",
-	"old/template",
 	"os/exec",
 	"os",
 	"os/signal",

What version of Go are you using (go version)?

go version go1.8.1 gccgo (Debian 7.1.0-8) 7.1.0 linux/s390x

What operating system and processor architecture are you using (go env)?

Debian on s390x

What did you do?

go get golang.org/x/tools
cd $GOPATH/src/golang.org/x/tools
go get -t -v ./...
go test -v ./go/internal/gccgoimporter/...

(Note: There were other issues with other tests, when the full go test ./... is run, but I'll limit the scope just to gccgoimporter in this issue.)

What did you expect to see?

All tests PASS.

What did you see instead?

=== RUN   TestInstallationImporter
--- FAIL: TestInstallationImporter (0.44s)
	gccgoinstallation_test.go:173: old/regexp: could not find export data (tried /usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7:/usr/lib/gcc/s390x-linux-gnu/7/../../../s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7/../../../../lib:/lib/s390x-linux-gnu:/lib/../lib:/usr/lib/s390x-linux-gnu:/usr/lib/../lib:/usr/lib/gcc/s390x-linux-gnu/7/../../..:.)
	gccgoinstallation_test.go:173: old/template: could not find export data (tried /usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7:/usr/lib/gcc/s390x-linux-gnu/7/../../../s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7/../../../../lib:/lib/s390x-linux-gnu:/lib/../lib:/usr/lib/s390x-linux-gnu:/usr/lib/../lib:/usr/lib/gcc/s390x-linux-gnu/7/../../..:.)
	gccgoinstallation_test.go:180: old/regexp: could not find export data (tried /usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7:/usr/lib/gcc/s390x-linux-gnu/7/../../../s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7/../../../../lib:/lib/s390x-linux-gnu:/lib/../lib:/usr/lib/s390x-linux-gnu:/usr/lib/../lib:/usr/lib/gcc/s390x-linux-gnu/7/../../..:.)
	gccgoinstallation_test.go:180: old/template: could not find export data (tried /usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/s390x-linux-gnu/go/7:/usr/lib/s390x-linux-gnu/go/7/s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7:/usr/lib/gcc/s390x-linux-gnu/7/../../../s390x-linux-gnu:/usr/lib/gcc/s390x-linux-gnu/7/../../../../lib:/lib/s390x-linux-gnu:/lib/../lib:/usr/lib/s390x-linux-gnu:/usr/lib/../lib:/usr/lib/gcc/s390x-linux-gnu/7/../../..:.)

Many thanks!

@gopherbot gopherbot modified the milestones: Unreleased, Gccgo Jul 6, 2017
@gopherbot
Copy link

Change https://golang.org/cl/91656 mentions this issue: go/internal/gccgoimporter: remove old and exp gccgo packages in test

@golang golang locked and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants