Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: Undefined type referred to in function comment #20905

Closed
fawick opened this issue Jul 5, 2017 · 2 comments
Closed

runtime/pprof: Undefined type referred to in function comment #20905

fawick opened this issue Jul 5, 2017 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@fawick
Copy link
Contributor

fawick commented Jul 5, 2017

What version of Go are you using (go version)?

1.9beta

What did you do?

Read documentation of runtime/pprof for Profiler Labels (http://tip.golang.org/pkg/runtime/pprof/#Labels)

What did you expect to see?

The function comment for http://tip.golang.org/pkg/runtime/pprof/#Labels
should describe the return value as type LabelSet.

What did you see instead?

The typename returned by http://tip.golang.org/pkg/runtime/pprof/#Labels
is LabelSet, but the documentation string refers to it as LabelList.
@fawick
Copy link
Contributor Author

fawick commented Jul 5, 2017

Sent fix as https://go-review.googlesource.com/47470

@gopherbot
Copy link

CL https://golang.org/cl/47470 mentions this issue.

@ALTree ALTree added this to the Go1.9 milestone Jul 5, 2017
@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. Documentation labels Jul 5, 2017
@golang golang locked and limited conversation to collaborators Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@fawick @ALTree @gopherbot