Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/arch/arm/armasm: incorrect disassembled instructions in go/plan9 syntax #20897

Closed
benshi001 opened this issue Jul 4, 2017 · 2 comments
Closed

x/arch/arm/armasm: incorrect disassembled instructions in go/plan9 syntax #20897

benshi001 opened this issue Jul 4, 2017 · 2 comments
Labels
FrozenDueToAge

Comments

@benshi001
Copy link
Member

benshi001 commented Jul 4, 2017 •
edited

In the disassembler, some instructions are renamed in go/plan9 syntax, such as
LDR -> MOVW
STR -> MOVW
LDRB -> MOVBU
LDRSB -> MOVBS
STRB -> MOVB
LDRH -> MOVHU
LDRSH -> MOVHSH
STRH -< MOVH

But,
VLDR.F32 // memory -> single float register, should be MOVF
VLDR.F64 // memory -> double float register, should be MOVD
VSTR.F32 // single float register -> memory, should be MOVF
VSTR.F64 // double float register -> memory, should be MOVD
@gopherbot
Copy link

CL https://golang.org/cl/47360 mentions this issue.

@gopherbot
Copy link

Change https://golang.org/cl/49530 mentions this issue: cmd/vendor/golang.org/x/arch: pull updates from x repo

gopherbot pushed a commit that referenced this issue Aug 16, 2017
@cherrymui
cmd/vendor/golang.org/x/arch: pull updates from x repo
56b62c7 
Vendor from golang.org/x/arch (commit f185940).

Implements #19157

Updates #12840
Updates #20762
Updates #20897
Updates #20096
Updates #20766
Updates #20752
Updates #20096
Updates #19142

Change-Id: Idefb8ba2c355dc07f3b9e8dcf5f00173256a0f0f
Reviewed-on: https://go-review.googlesource.com/49530
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @benshi001