Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httptest: regression in using custom Server #20871

Closed
dsnet opened this issue Jun 30, 2017 · 1 comment
Closed

net/http/httptest: regression in using custom Server #20871

dsnet opened this issue Jun 30, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@dsnet
Copy link
Member

dsnet commented Jun 30, 2017

3b988eb caused a regression such that it initializes an unexported field in NewServer and NewTLSServer. Any prior methods of created a Server without using NewTLSServer now panics when calling StartTLS since the unexported client field is not initialized. Instead, the logic should do lazy initialization.
@dsnet dsnet self-assigned this Jun 30, 2017
@dsnet dsnet added this to the Go1.9 milestone Jun 30, 2017
@dsnet dsnet added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 30, 2017
@gopherbot
Copy link

CL https://golang.org/cl/47353 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 30, 2018
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
2 participants
@dsnet @gopherbot