Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/pe: Missing IMAGE_FILE_MACHINE_ARM64 machine magic constant #20849

Closed
mattimo opened this issue Jun 29, 2017 · 2 comments
Closed

debug/pe: Missing IMAGE_FILE_MACHINE_ARM64 machine magic constant #20849

mattimo opened this issue Jun 29, 2017 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Go1.11

Comments

@mattimo
Copy link

mattimo commented Jun 29, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.8.3 linux/amd64 but also checked tip.golang.org/pkg/debug/pe

What did you do?

Tried to load a arm64 linux kernel image to inspect the PE header (used to UEFI) using pe.Open()

see https://play.golang.org/p/FFjD3r8M6N

What did you expect to see?

Loads fine

What did you see instead?

Could not open file: Unrecognised COFF file header machine value of 0xaa64.

At least one of the problems is that the IMAGE_FILE_MACHINE_ARM64 that was added with Revision 10 of the "Microsoft Portable Executable and Common Object File Format Specification" (also known pecoff.docx), constant is not defined.
@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Jun 29, 2017
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Jun 29, 2017
@alexbrainman
Copy link
Member

At least one of the problems is that the IMAGE_FILE_MACHINE_ARM64 that was added with Revision 10

I think it is OK to add IMAGE_FILE_MACHINE_ARM64 and use it in debug/pe.

@mattimo is there way to test this new code? Is there a simple way to create arm64 PE object file?

Alex

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@gopherbot
Copy link

Change https://golang.org/cl/117056 mentions this issue: debug/pe: add IMAGE_FILE_MACHINE_ARM64

@golang golang locked and limited conversation to collaborators Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
5 participants
@rsc @mattimo @ianlancetaylor @gopherbot @alexbrainman