Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestReadFromTimeoutFluctuation and TestWriteTimeoutFluctuation trybot flake on OpenBSD #20838

Closed
bradfitz opened this issue Jun 28, 2017 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bradfitz
Copy link
Contributor

Test flake on OpenBSD:

https://storage.googleapis.com/go-build-log/4f0cbd68/openbsd-amd64-60_a0ca068c.log

--- FAIL: TestReadFromTimeoutFluctuation (1.48s)
	timeout_test.go:727: ReadFrom took over 1s; expected 0.1s
--- FAIL: TestWriteTimeoutFluctuation (1.96s)
	timeout_test.go:769: Write took over 1s; expected 0.1s
FAIL
FAIL	net	33.085s
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure. labels Jun 28, 2017
@bradfitz bradfitz added this to the Go1.9Maybe milestone Jun 28, 2017
@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.10 Jul 20, 2017
@geirskjo
Copy link

I ran these tests on my OpenBSD system (6.1 GENERIC.MP#6 amd64) with Go version devel +a9257b6b69 Wed Aug 16 05:13:18 2017 +0000 openbsd/amd64 on a updated repo.

They did not fail. Anything I can do to help?

[net]$ go test -v -run TimeoutFluctuation -count 8
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.11s)
--- PASS: TestReadFromTimeoutFluctuation (0.11s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.12s)
--- PASS: TestWriteTimeoutFluctuation (0.12s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
=== RUN TestReadTimeoutFluctuation
=== RUN TestReadFromTimeoutFluctuation
=== RUN TestWriteTimeoutFluctuation
--- PASS: TestReadTimeoutFluctuation (0.11s)
--- PASS: TestWriteTimeoutFluctuation (0.14s)
--- PASS: TestReadFromTimeoutFluctuation (0.12s)
PASS
Socket statistical information:
(inet4, stream, default): opened=32 connected=16 listened=16 accepted=0 closed=32 openfailed=0 connectfailed=16 listenfailed=0 acceptfailed=0 closefailed=0
(inet4, datagram, default): opened=16 connected=8 listened=0 accepted=0 closed=16 openfailed=0 connectfailed=0 listenfailed=0 acceptfailed=0 closefailed=0

ok net 1.877s

@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Unplanned Jan 3, 2018
@gopherbot
Copy link

Change https://golang.org/cl/105095 mentions this issue: net, net/internal/socktest: make concurrent socket system calls in test safe

@bcmills
Copy link
Contributor

bcmills commented Jan 22, 2021

Duplicate of #36108

@bcmills bcmills marked this as a duplicate of #36108 Jan 22, 2021
@bcmills bcmills closed this as completed Jan 22, 2021
@golang golang locked and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

5 participants