Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: TestIgnorePipeErrorOnSuccess/10MB often hangs on netbsd-amd64-71 #20835

Closed
bradfitz opened this issue Jun 28, 2017 · 3 comments
Closed

os/exec: TestIgnorePipeErrorOnSuccess/10MB often hangs on netbsd-amd64-71 #20835

bradfitz opened this issue Jun 28, 2017 · 3 comments
Labels
FrozenDueToAge help wanted OS-NetBSD
Milestone
Go1.10

Comments

@bradfitz
Copy link
Contributor

As of e1ced32 (just past Go1.9beta2), I see occasional hangs during os/exec's TestIgnorePipeErrorOnSuccess/10MB on netbsd-amd64-71 (NetBSD 7.1).

With gomote, it sometimes hangs in:

$ gomote run $MOTE go/bin/go test -short -v os/exec
=== RUN   TestDedupEnv
--- PASS: TestDedupEnv (0.00s)
=== RUN   TestPrefixSuffixSaver
--- PASS: TestPrefixSuffixSaver (0.00s)
=== RUN   TestLookPathNotFound
--- PASS: TestLookPathNotFound (0.00s) 
=== RUN   TestLookPathUnixEmptyPath
--- PASS: TestLookPathUnixEmptyPath (0.00s)
=== RUN   TestCredentialNoSetGroups
--- PASS: TestCredentialNoSetGroups (0.00s)
=== RUN   TestWaitid
=== RUN   TestEcho
--- PASS: TestEcho (0.00s)
=== RUN   TestCommandRelativeName
--- PASS: TestCommandRelativeName (0.00s)
=== RUN   TestCatStdin
--- PASS: TestCatStdin (0.00s)
=== RUN   TestEchoFileRace
--- PASS: TestEchoFileRace (0.00s)
=== RUN   TestCatGoodAndBadFile
--- PASS: TestCatGoodAndBadFile (0.03s)
=== RUN   TestNoExistBinary
--- PASS: TestNoExistBinary (0.00s)
=== RUN   TestExitStatus
--- PASS: TestExitStatus (0.00s)
=== RUN   TestPipes
--- PASS: TestPipes (0.01s)
=== RUN   TestStdinClose
--- PASS: TestStdinClose (0.02s)
=== RUN   TestStdinCloseRace
--- PASS: TestStdinCloseRace (0.02s)   
=== RUN   TestPipeLookPathLeak
--- PASS: TestPipeLookPathLeak (0.00s) 
=== RUN   TestExtraFilesFDShuffle
--- SKIP: TestExtraFilesFDShuffle (0.00s)
        exec_test.go:422: flaky test; see https://golang.org/issue/5780
=== RUN   TestExtraFiles
--- PASS: TestExtraFiles (0.06s)
        exec_test.go:416: TestExtraFiles: Something already leaked - closed fd 7
        exec_test.go:416: TestExtraFiles: Something already leaked - closed fd 8
        exec_test.go:416: TestExtraFiles: Something already leaked - closed fd 9
=== RUN   TestExtraFilesRace
--- PASS: TestExtraFilesRace (0.07s)   
=== RUN   TestHelperProcess
--- PASS: TestHelperProcess (0.00s)
=== RUN   TestIgnorePipeErrorOnSuccess 
=== RUN   TestIgnorePipeErrorOnSuccess/10MB
^C
@bradfitz bradfitz added this to the Go1.10 milestone Jun 28, 2017
@bradfitz bradfitz mentioned this issue Jun 28, 2017
Closed
@bradfitz
Copy link
Contributor Author

/cc @bsiegert

@gopherbot
Copy link

CL https://golang.org/cl/47036 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 28, 2017
@bradfitz
doc: document the state of NetBSD in the Go 1.9 release notes
3200207 
Updates #20836
Updates #19339
Updates #19652
Updates #20835
Updates #16511
Updates #10166
Updates #8574

Change-Id: If9a7f560489f1a8d628dafab227925bd8989326e
Reviewed-on: https://go-review.googlesource.com/47036
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz
Copy link
Contributor Author

Fixed by requiring NetBSD 8+ for Go 1.10.

Documentation bug is #22911

@bradfitz bradfitz mentioned this issue Dec 2, 2017
Closed
@golang golang locked and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted OS-NetBSD
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot