Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: auto-remove old Needs labels #20819

Closed
bradfitz opened this issue Jun 27, 2017 · 5 comments
Closed

x/build/cmd/gopherbot: auto-remove old Needs labels #20819

bradfitz opened this issue Jun 27, 2017 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) Debugging FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

Feature request from @rsc:

When gopherbot sees a Needs-Foo label added, remove any earlier Needs-Bar label.
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 27, 2017
@bradfitz bradfitz self-assigned this Jun 27, 2017
@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 27, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jun 27, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 27, 2017
@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 27, 2017
@gopherbot gopherbot removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 27, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 27, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 27, 2017
@gopherbot
Copy link

CL https://golang.org/cl/46838 mentions this issue.

@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 27, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 27, 2017
@bradfitz bradfitz reopened this Jun 29, 2017
@bradfitz bradfitz added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsFix The path to resolution is known, but the work has not been done. Debugging and removed NeedsFix The path to resolution is known, but the work has not been done. labels Jun 29, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz bradfitz added Debugging NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Debugging labels Jun 29, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@gopherbot
Copy link

CL https://golang.org/cl/47133 mentions this issue.

@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 29, 2017
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@bradfitz bradfitz added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 29, 2017
@gopherbot gopherbot removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 29, 2017
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 29, 2017
@gopherbot gopherbot removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 29, 2017
@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@gopherbot
Copy link

CL https://golang.org/cl/47134 mentions this issue.

@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 29, 2017
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 29, 2017
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz
Copy link
Contributor Author

Okay, between https://golang.org/cl/47134 and https://golang.org/cl/47133, this now reacts immediately, subsecond.

gopherbot pushed a commit to golang/build that referenced this issue Jun 29, 2017
@bradfitz
maintner: don't use github caching transport after getting webhook up…
070f178 
…date

If we got a webhook update, we know there's new data. We're not in
polling mode, so don't use the caching transport.

The caching transport was being too agressive and we were missing
label changes to issues, since the Issues.ListByRepo call to get
issues sorted by mod time descending was being cached.

This speeds up gopherbot. Gopherbot can react in realtime to changes,
but only if they make it into maintner in realtime.

Updates golang/go#20819

Change-Id: I5c0a0bbcb4bf0d9d484b9279ff5a80732b4e1269
Reviewed-on: https://go-review.googlesource.com/47133
Reviewed-by: Andrew Bonventre <andybons@google.com>
@rsc
Copy link
Contributor

rsc commented Jul 6, 2017

Awesome, thanks.

@golang golang locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) Debugging FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot