Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/syntax: needs regression test framework #20800

Closed
griesemer opened this issue Jun 26, 2017 · 6 comments
Closed

cmd/compile/internal/syntax: needs regression test framework #20800

griesemer opened this issue Jun 26, 2017 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.11

Comments

@griesemer
Copy link
Contributor

Reminder issue: The syntax package doesn't have a good setup for adding regression tests.
@griesemer griesemer self-assigned this Jun 26, 2017
@griesemer griesemer modified the milestones: Unplanned, Go1.10 Jun 26, 2017
@griesemer
Copy link
Contributor Author

Marking for 1.10 simply so it stays on the radar.

@griesemer
Copy link
Contributor Author

Test case for #20789 (https://go-review.googlesource.com/#/c/46713/) could move there.

@griesemer griesemer changed the title cmd/compile/internal/syntax: could use a test framework cmd/compile/internal/syntax: needs regression test framework Jun 26, 2017
@griesemer griesemer modified the milestones: Go1.10, Go1.11 Nov 3, 2017
@griesemer
Copy link
Contributor Author

Test case for #23434 (https://go-review.googlesource.com/c/go/+/87898, corresponding go/parser fix) should be added here.

@griesemer
Copy link
Contributor Author

Test case for #23385 should be added here.

@gopherbot
Copy link

Change https://golang.org/cl/88335 mentions this issue: cmd/compile/internal/syntax: implement regression test harness for syntax errors

@gopherbot
Copy link

Change https://golang.org/cl/88336 mentions this issue: cmd/compile/internal/syntax: added test cases for recent fixes

gopherbot pushed a commit that referenced this issue Feb 12, 2018
@griesemer
cmd/compile/internal/syntax: added test cases for recent fixes
945872e 
R=go1.11.

Now that we have a syntax error test harness, we can add the
proper tests for the recent parser fixes.

For #20800.
For #20789.
For #23385.
For #23434.

A test for #20789 already exists in test/fixedbugs, but this
is the better location for that test. But leaving the existing
one where it is as well.

Change-Id: I5937b9b63bafd1efab467a00344302e717976171
Reviewed-on: https://go-review.googlesource.com/88336
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@golang golang locked and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@griesemer @gopherbot