Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: various TestCloneNEWUSERAndRemap/TestEmptyCredGroups test failures #20796

Closed
ALTree opened this issue Jun 26, 2017 · 10 comments
Closed

syscall: various TestCloneNEWUSERAndRemap/TestEmptyCredGroups test failures #20796

ALTree opened this issue Jun 26, 2017 · 10 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.10

Comments

@ALTree
Copy link
Member

ALTree commented Jun 26, 2017 •
edited 

$ go version
go version devel +b4dd1d9 Sun Jun 25 15:57:18 2017 +0000 linux/amd64

syscall tests in exec_linux_test.go have a fair amount of checks to make sure we skip the tests if we're in no condition to successfully run them, but there must be something missing because I'm seeing the following failures on a GNU/Linux system I use when I run all.bash.

$ cd src/syscall
$ go test 
--- FAIL: TestCloneNEWUSERAndRemapNoRootDisableSetgroups (0.00s)
	exec_linux_test.go:84: Cmd failed with err fork/exec /usr/bin/whoami: invalid argument, output: 
--- FAIL: TestCloneNEWUSERAndRemapNoRootSetgroupsEnableSetgroups (0.00s)
	exec_linux_test.go:124: Unprivileged gid_map rewriting with GidMappingsEnableSetgroups must fail
--- FAIL: TestEmptyCredGroupsDisableSetgroups (0.00s)
	exec_linux_test.go:132: fork/exec /usr/bin/whoami: invalid argument
FAIL
exit status 1
FAIL	syscall	0.021s

This is on a CentOS 7.2 system with kernel 3.10.0-327.36.3.el7.x86_64 from an unprivileged user. The same tests are (correctly) skipped on other GNU/Linux systems I tested, which makes me think something is missing from the "skipping-test" logic.

Not incredibly important but this makes impossible to run all.bash and complete it successfully on this system.
@ALTree ALTree added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 26, 2017
@ALTree ALTree added this to the Go1.10 milestone Jun 26, 2017
@ianlancetaylor
Copy link
Contributor

Would be nice to get this into 1.9 if we can figure it out.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.9Maybe, Go1.10 Jun 26, 2017
@ALTree
Copy link
Member Author

ALTree commented Jun 28, 2017

I just realized this is a dup of #16283, which was closed as WONTFIX.

@bradfitz
Copy link
Contributor

Okay, you can close it if you'd like.

But can't we detect that user namespaces or whatever aren't available and t.Skip the test instead?

@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 29, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Maybe Jun 29, 2017
@ALTree
Copy link
Member Author

ALTree commented Jun 29, 2017

But can't we detect that user namespaces or whatever aren't available and t.Skip the test instead?

Yes, I think that would be nice.

@Mike-Dunton
Copy link

It would be nice to get a patch to skip the tests. Currently blocked on building this in my pipeline

@jessfraz
Copy link
Contributor

I can fix

@jessfraz
Copy link
Contributor

feel free to ping me on these in the future

@gopherbot
Copy link

CL https://golang.org/cl/49310 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/49311 mentions this issue.

@ALTree
Copy link
Member Author

ALTree commented Jul 17, 2017

@jessfraz thanks!

@ALTree ALTree mentioned this issue Oct 23, 2017
Closed
@golang golang locked and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
6 participants
@bradfitz @jessfraz @ianlancetaylor @Mike-Dunton @ALTree @gopherbot