Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: wrong grpc import path #20776

Closed
s-mang opened this issue Jun 23, 2017 · 1 comment
Closed

x/build/cmd/coordinator: wrong grpc import path #20776

s-mang opened this issue Jun 23, 2017 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@s-mang
Copy link
Contributor

s-mang commented Jun 23, 2017

AFAICT, build/cmd/coordinator/coordinator.go build/maintner/maintnerd/apipb/apib.pb.go are using the wrong import path for grpc.

looks like maintainerd/apib.pb.go gets the import path from something else on go4.org, go4.org/grpc-codegen/protoc-gen-go4grpc maybe?

anyway, go build golang.org/x/build/cmd/coordinator:

coordinator.go:46:2: code in directory $HOME/go/src/go4.org/grpc expects import "grpc.go4.org"
@gopherbot gopherbot added this to the Unreleased milestone Jun 23, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 23, 2017
@s-mang
Copy link
Contributor Author

s-mang commented Jun 23, 2017

whoops, had out of date master. already fixed this morning.

@s-mang s-mang closed this as completed Jun 23, 2017
@golang golang locked and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants