Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/format: hasUnsortedImports should also test grouped imports (TODO) #20740

Open
griesemer opened this issue Jun 20, 2017 · 0 comments
Open

go/format: hasUnsortedImports should also test grouped imports (TODO) #20740

griesemer opened this issue Jun 20, 2017 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@griesemer
Copy link
Contributor

Reminder to resolve TODO in go/format/format.go:hasUnsortedImports: This function always returns true if there are grouped imports, which causes a lot of extra work even if those imports are sorted.
@griesemer griesemer self-assigned this Jun 20, 2017
@griesemer griesemer added this to the Go1.10 milestone Jun 20, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@griesemer griesemer modified the milestones: Go1.12, Go1.13 Dec 11, 2018
@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@rsc @griesemer @seankhliao