blog: document Code generated convention in the Generating code blog post #20720
Labels
Documentation
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
bradfitz
added
the
NeedsFix
|
Sounds good. Feel free to send. But I wouldn't link to https://golang.org/s/generatedcode, at least until we have a better target URL for that shortlink. |
|
Ok, I'll skip adding the link, but will send a CL for -// generated by stringer -type Pill pill.go; DO NOT EDIT
+// Code generated by stringer -type Pill pill.go; DO NOT EDIT.@bradfitz How far away is maintner from being able to convert GitHub pull requests to Gerrit CLs? I'd be happy to beta-test ;) |
|
Far. |
|
@mewmew - PRs work now. Want to send one ? |
mewmew
added a commit
to mewpull/blog
that referenced
this issue
Mar 15, 2019
|
Change https://golang.org/cl/167763 mentions this issue: |
gopherbot
pushed a commit
to golang/website
that referenced
this issue
May 26, 2021
Fixes golang/go#20720. Change-Id: Iabeadddba92d6d51f873d817446eb79f20694be6 GitHub-Last-Rev: bd9501d806e08aff6cf230d1490fee14e2ba5e6f GitHub-Pull-Request: golang/blog#20 Reviewed-on: https://go-review.googlesource.com/c/blog/+/167763 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> X-Blog-Commit: 933f9aa4742a8ce65b9b4e3c4c7226744d3adb2e
passionSeven
added a commit
to passionSeven/website
that referenced
this issue
Oct 18, 2022
Fixes golang/go#20720. Change-Id: Iabeadddba92d6d51f873d817446eb79f20694be6 GitHub-Last-Rev: bd9501d806e08aff6cf230d1490fee14e2ba5e6f GitHub-Pull-Request: golang/blog#20 Reviewed-on: https://go-review.googlesource.com/c/blog/+/167763 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> X-Blog-Commit: 933f9aa4742a8ce65b9b4e3c4c7226744d3adb2e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As the Go community has reached consensus on the convention to use for distinguishing machine-generated code (i.e. https://golang.org/s/generatedcode), it would be good if the Generating code article on the Go blog was updated to reflect this. Preferably a link could also be added from the Generating code article to https://golang.org/s/generatedcode
In particular, the Generating code article is still using the convention
// generated by stringer -type Pill pill.go; DO NOT EDIT. Since the blog post is the first hit (for me at least) on Google which searching for generate code golang, the article should in my opinion be updated so that new Gophers learn the newly established convention.The text was updated successfully, but these errors were encountered: