Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TimeoutHandler doesn't set a timeout on Request.Context #20712

Closed
jmhodges opened this issue Jun 17, 2017 · 2 comments
Closed

net/http: TimeoutHandler doesn't set a timeout on Request.Context #20712

jmhodges opened this issue Jun 17, 2017 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@jmhodges
Copy link
Contributor

jmhodges commented Jun 17, 2017

On Go version 1.8.3, net/http.TimeoutHandler doesn't apply context.WithTimeout to the passed in http.Request's context. It's desirable now that context is everywhere in the stdlib. It seems like it might also simplify the timeoutHandler.ServeHTTP implementation.

This also seems to be the case in 1.9beta1.

@odeke-em
Copy link
Member

/cc @bradfitz

@bradfitz bradfitz added this to the Go1.10 milestone Jun 21, 2017
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 21, 2017
@gopherbot
Copy link

CL https://golang.org/cl/46412 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants