Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/devapp: migrate to GKE or Flex #20691

Closed
bradfitz opened this issue Jun 15, 2017 · 10 comments
Closed

x/build/devapp: migrate to GKE or Flex #20691

bradfitz opened this issue Jun 15, 2017 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@bradfitz
Copy link
Contributor

https://dev.golang.org/ is currently on App Engine classic and that's holding us back in a number of ways.

For one, it's Go 1.6 only.

But mostly it doesn't let us use maintner.

Before we do a number of other things we want to do, we need to migrate it to Flex or a GKE service.

According to @broady, we can't currently run an App Engine Flex app on *.golang.org due to some Google-internal configuration issues with our *.golang.org setup. See http://b/62618033 for details.

But we can run a Go webserver on GKE and route to that instead, like we do for:

https://maintner.golang.org/
https://pubsubhelper.golang.org/

That is my preference. We can always move to Flex later if it buys us anything.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Jun 15, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 15, 2017
@andybons andybons self-assigned this Jun 15, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 15, 2017
@bradfitz
Copy link
Contributor Author

Note that https://dev.golang.org/ has several dashboards, but we only need to work on porting the one that's often used for the initial migration.

The important one is:
https://dev.golang.org/release

The ones that can (and should) wait until later are:
https://dev.golang.org/cl
https://dev.golang.org/dash#all

Those last two are redundant and should be merged, be prettier, and use maintner to have live & better data.

And https://dev.golang.org/stats is not very useful at the moment. We can port it at some point, though. But don't let it block you.

@gopherbot
Copy link

CL https://golang.org/cl/46133 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 20, 2017
Since we can’t run an App Engine Flex app on *.golang.org (see
issue), the Flex app.yaml file is removed.

Updates golang/go#20691

Change-Id: Id775962349a88b119c9fe671f9a5180f70528836
Reviewed-on: https://go-review.googlesource.com/46133
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46210 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 21, 2017
+ Remove superfluous check for PORT env var since only the flag
  will be used.
+ Remove HTML being written to the page before escaping step,
  causing jank.
+ Grab the GitHub token from GCE metadata if it’s available.

Updates golang/go#20691

Change-Id: I10fbc163ee91907ef0b843c823f40fd87a62f476
Reviewed-on: https://go-review.googlesource.com/46210
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46465 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 22, 2017
Updates golang/go#20691

Change-Id: Ia92422213111a965136c33359c16b17ca3fabec5
Reviewed-on: https://go-review.googlesource.com/46465
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46710 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 26, 2017
Updates golang/go#20691

Change-Id: I816fc059473ded8ef85e9bb6fb6cb73e41ba21d6
Reviewed-on: https://go-review.googlesource.com/46710
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46720 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 26, 2017
Updates golang/go#20691

Change-Id: If0f160713496b1c9ebceacb4975e9afa44539e5a
Reviewed-on: https://go-review.googlesource.com/46720
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46832 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 27, 2017
This change removes all but the / and /release endpoints, moving
things around and deleting all App Engine-specific code while
attempting to not make many core logic changes (those will come in a
follow-up change).

Updates golang/go#20691

Change-Id: Ie8fa184578177cc2cb3c070e9108cf27d9e6f689
Reviewed-on: https://go-review.googlesource.com/46832
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46837 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 27, 2017
Updates golang/go#20691

Change-Id: I3c691c647860d541d53497c9923383421a5d2298
Reviewed-on: https://go-review.googlesource.com/46837
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46911 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jun 27, 2017
Updates golang/go#20691

Change-Id: I5247683f62cbe922a880246dbd2e99e31686e2d3
Reviewed-on: https://go-review.googlesource.com/46911
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons
Copy link
Member

dev.golang.org now points to the GKE app

@golang golang locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants