New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/openpgp: ReadArmoredKeyRing: unsupported feature: unknown critical signature subpacket type 6 #20686
Comments
Unfortunately this doesn't work because the openpgp doesn't fully implement parsing of this keyring. See golang/go#20686
openpgp.ReadEntity is inlined and adapted to bypass the unsupported packets.
@SCKelemen, what do you mean by writing your name on a bunch of bugs like this? |
@bradfitz I want to watch the issue, so it comes up in my notifications involving me. If these issues aren't being worked on, I can try and take them on in my 20% time. |
Can't you just hit the Subscribe button in the right sidebar? |
I'm already subscribed, just overwhelmed by all of the notifications. I'll take some time and unfollow all the other issues |
@SCKelemen I suggest finding some other way of writing down the issues you intend to look at later. For example, personally, I keep them organized in a few folders with my other bookmarks. Writing comments on issues updates a lot of people so it's not a good way to keep track of things for yourself. |
I asked why you're dropping your name in places, and you said "to watch the issue". I then asked why you don't subscribe to it, and you said you get too many notifications. I'm confused. |
Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed. If this is a security issue, please email security@golang.org and we will assess it and provide a fix. If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here. If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one. |
What version of Go are you using (
go version
)?go1.8.3
golang.org/x/crypto latest (commit 850760c June 13th, 2017)
What operating system and processor architecture are you using (
go env
)?linux/amd64
What did you do?
Parse a public key using golang.org/x/crypto/openpgp
Full test code including the failing key (well known key working with GPG):
What did you expect to see?
What did you see instead?
It looks like keybase has worked on this issue and may have a partial fix or maybe just a workaround. See keybase/go-crypto#17
The text was updated successfully, but these errors were encountered: