build: upstream OpenBSD patches to master and/or Go 1.4 branch #20672

henryas · 2017-06-14T16:55:04Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

Go1.4.3

What operating system and processor architecture are you using (`go env`)?

OpenBSD 386

What did you do?

I downloaded Go1.4.3 source from Go's website and failed to build Go's toolchain (Go1.4.3) in my OpenBSD/386 machine. I made a post in Golang Nuts and Dave Cheney suggested to look for possible patches in OpenBSD's ports. It turned out that there are patches that exist in OpenBSD's version that do not exist in Go's official version.

The OpenBSD's version builds just fine on my machine, but the official version does not.

I have included the OpenBSD port for Go1.4.3 for your reference and perhaps someone could integrate their patches into the official version.

Thanks

Henry
go.tar.gz

The text was updated successfully, but these errors were encountered:

bradfitz · 2017-06-14T17:09:37Z

This is probably an easier way to look at them:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/lang/go/patches/

Looks like Joel (@4a6f656c) is the author or maintainer of them.

Joel, do you want to upstream them? We'd prefer if they were upstream.

ALTree · 2017-06-14T17:32:09Z

I downloaded Go1.4.3 source from Go's website

This may be a silly question but... why? If you are bootstrapping, you should use go1.4-bootstrap, not go1.4.3

bradfitz · 2017-06-14T17:38:38Z

@ALTree, I assumed the issue is that they're not on the 1.4 release branch, hence the necessary changes are not in the go1.4-bootstrap tarball.

ALTree · 2017-06-14T17:42:39Z

Ah, so you're asking them to upstream the changes to go1.4-bootstrap and then we'll publish a new bootstrap release?

I thought you were asking them to apply the patches to go1.4.3 (which is unmaintained and it's not usable for bootstrapping, even on many linux system), that's why I was confused.

bradfitz · 2017-06-14T18:12:54Z

Ah, so you're asking them to upstream the changes to go1.4-bootstrap and then we'll publish a new bootstrap release?

Yes.

4a6f656c · 2017-09-25T17:44:26Z

@bradfitz - I did not realise that go1.4-bootstrap tarball existed and just stumbled across this issue. I'm more than happy to upstream the changes - what's the process for targeting the release-branch.go1.4 branch (I don't seem to be able to find any references re this)?

ianlancetaylor · 2017-09-25T18:08:36Z

Contributing to the 1.4 release branch is the same as the usual contribution process, but first run git pull; git checkout release-branch.go1.4. Then you can git change, git mail as usual.

Note that the trybots do not work for the 1.4 release branch. In fact, there's not much automated testing at all.

And, of course, patches must be minimal and completely safe.

4a6f656c · 2017-09-25T18:09:39Z

@ianlancetaylor - ack, thanks.

gopherbot · 2017-09-25T18:23:18Z

Change https://golang.org/cl/66070 mentions this issue: [release-branch.go1.4] cmd/link: specify correct size for dynamic symbols in 386 elf output

gopherbot · 2017-09-25T18:25:35Z

Change https://golang.org/cl/66071 mentions this issue: [release-branch.go1.4] runtime: stop using sigreturn on openbsd/386

gopherbot · 2017-09-25T18:32:13Z

Change https://golang.org/cl/66072 mentions this issue: [release-branch.go1.4] runtime, syscall: update openbsd for changes to syskill

gopherbot · 2017-09-25T18:40:35Z

Change https://golang.org/cl/66073 mentions this issue: [release-branch.go1.4] time: Skip TestParseInLocation test.

…bols in 386 elf output This is a backport of https://golang.org/cl/22912 to the Go 1.4 branch. Updates #20672 Change-Id: Id71c0c4596a599c5293b013f68894f6ee13e06d6 Reviewed-on: https://go-review.googlesource.com/66070 Reviewed-by: Ian Lance Taylor <iant@golang.org>

In future releases of OpenBSD, the sigreturn syscall will no longer exist. As such, stop using sigreturn on openbsd/386 and just return from the signal trampoline. This is a backport of https://golang.org/cl/23024 to the Go 1.4 branch. Updates #20672 Change-Id: Ia1caf9427c51a6871f51dbff06720f3158e38c68 Reviewed-on: https://go-review.googlesource.com/66071 Reviewed-by: Ian Lance Taylor <iant@golang.org>

…o syskill Change the openbsd runtime to use the current sys_kill and sys_thrkill system calls. This is a backport of https://golang.org/cl/34093 to the Go 1.4 branch. Updates #20672 Change-Id: I4fde5bad2fbfbe99196053d69ba235b49ddb32c8 Reviewed-on: https://go-review.googlesource.com/66072 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This test is now failing due to tz data updates (see issue #19457) - skip the test since it does not impact the use of Go 1.4 for bootstrapping. Similar to issue #17545. Updates #20672 Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d Reviewed-on: https://go-review.googlesource.com/66073 Reviewed-by: Ian Lance Taylor <iant@golang.org>

4a6f656c · 2017-10-03T12:16:54Z

@bradfitz I believe a new go1.4-release tarball can be rolled and this can then be closed out.

4a6f656c · 2017-11-21T16:46:31Z

@bradfitz any chance of getting a new go1.4-release tarball spun?

bradfitz · 2017-11-22T01:34:16Z

Done. https://storage.googleapis.com/golang/go1.4-bootstrap-20171003.tar.gz

gopherbot · 2017-11-22T01:37:38Z

Change https://golang.org/cl/79275 mentions this issue: cmd/upload: add support for updating go1.4-bootstrap-yyyymmdd.tar.gz

gopherbot · 2017-11-22T01:39:50Z

Change https://golang.org/cl/79276 mentions this issue: doc: update the URL of the latest go1.4 source snapshot

Updates #20672 Change-Id: I3c62b1606aec93e188255f1701c0af569d540016 Reviewed-on: https://go-review.googlesource.com/79276 Reviewed-by: Ian Lance Taylor <iant@golang.org>

Stop doing this by hand and automate it. Updates golang/go#20672 Change-Id: I2ff02053882f76406c220bf015dd21ad0c0dca1a Reviewed-on: https://go-review.googlesource.com/79275 Reviewed-by: Ian Lance Taylor <iant@golang.org>

gopherbot · 2017-11-26T16:32:05Z

Change https://golang.org/cl/79936 mentions this issue: doc: update URL of the go1.4 source snapshot to use dl.google.com

Updates #20672 Change-Id: I88a1d8693ef9d1e4758719603ce1f3c3f6b920bc Reviewed-on: https://go-review.googlesource.com/79936 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

bradfitz · 2017-12-05T05:29:46Z

@broady, can you update the website with this?

Cherry-pick 79276 and 79936 to the release branch?

…bols in 386 elf output This is a backport of https://golang.org/cl/22912 to the Go 1.4 branch. Updates golang#20672 Change-Id: Id71c0c4596a599c5293b013f68894f6ee13e06d6 Reviewed-on: https://go-review.googlesource.com/66070 Reviewed-by: Ian Lance Taylor <iant@golang.org>

In future releases of OpenBSD, the sigreturn syscall will no longer exist. As such, stop using sigreturn on openbsd/386 and just return from the signal trampoline. This is a backport of https://golang.org/cl/23024 to the Go 1.4 branch. Updates golang#20672 Change-Id: Ia1caf9427c51a6871f51dbff06720f3158e38c68 Reviewed-on: https://go-review.googlesource.com/66071 Reviewed-by: Ian Lance Taylor <iant@golang.org>

…o syskill Change the openbsd runtime to use the current sys_kill and sys_thrkill system calls. This is a backport of https://golang.org/cl/34093 to the Go 1.4 branch. Updates golang#20672 Change-Id: I4fde5bad2fbfbe99196053d69ba235b49ddb32c8 Reviewed-on: https://go-review.googlesource.com/66072 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This test is now failing due to tz data updates (see issue golang#19457) - skip the test since it does not impact the use of Go 1.4 for bootstrapping. Similar to issue golang#17545. Updates golang#20672 Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d Reviewed-on: https://go-review.googlesource.com/66073 Reviewed-by: Ian Lance Taylor <iant@golang.org>