Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: request backport for ppc64le linker fix to go 1.8 #20670

Closed
laboger opened this issue Jun 14, 2017 · 6 comments
Closed

cmd/link: request backport for ppc64le linker fix to go 1.8 #20670

laboger opened this issue Jun 14, 2017 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8.5

Comments

@laboger
Copy link
Contributor

laboger commented Jun 14, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.8.3

What operating system and processor architecture are you using (go env)?

Ubuntu ppc64le

A fix went upstream related to linking programs on ppc64le, affecting the build of very large programs as are found in Kubernetes and openshift. I'm requesting to backport this fix to the go 1.8 branch so it is in a go1.8.x, since many builds are still using go 1.8.x and will continue to use that version for a while.

The issue is #20497 fixed by CL 45130. If this is approved, I can take care of doing the backport.
@bradfitz
Copy link
Contributor

I'll let @ianlancetaylor decide.

But we may be closed enough to Go 1.9 that the answer might be to wait.

@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 14, 2017
@ianlancetaylor
Copy link
Contributor

I think it's OK to backport the CL for 1.8, but it's not enough to trigger a 1.8.4 release. We may never do a 1.8.4 release. I would suggest preparing the CL at your leisure, but don't commit it to the branch.

@ianlancetaylor ianlancetaylor added this to the Go1.8.4 milestone Jun 14, 2017
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 14, 2017
@gopherbot
Copy link

CL https://golang.org/cl/45756 mentions this issue.

@laboger
Copy link
Contributor Author

laboger commented Jun 14, 2017

@jcajka The above CL is the Go 1.8 backport of the fix for openshift on ppc64le.

@rsc rsc modified the milestones: Go1.8.4, Go1.8.5 Oct 4, 2017
@rsc
Copy link
Contributor

rsc commented Oct 13, 2017 •
edited

CL 45130 OK for Go 1.8.5.
It won't apply cleanly but this will be a good test.
CL 70837 OK for Go 1.8.5.

@rsc rsc added release-blocker CherryPickApproved Used during the release process for point releases and removed release-blocker labels Oct 13, 2017
@rsc rsc mentioned this issue Oct 14, 2017
Closed
@rsc
Copy link
Contributor

rsc commented Oct 26, 2017

go1.8.5 has been packaged and includes:

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:07:49 UTC

@rsc rsc closed this as completed Oct 26, 2017
@golang golang locked and limited conversation to collaborators Oct 26, 2018
@rsc rsc unassigned laboger Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8.5
Development

No branches or pull requests
5 participants
@bradfitz @rsc @ianlancetaylor @gopherbot @laboger