Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestIssue7573 now fails after commit b488073 #20664

Closed
siebenmann opened this issue Jun 13, 2017 · 1 comment
Closed

cmd/go: TestIssue7573 now fails after commit b488073 #20664

siebenmann opened this issue Jun 13, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.9

Comments

@siebenmann
Copy link

What version of Go are you using (go version)?

go version devel +538b3a5 Tue Jun 13 21:51:17 2017 +0000 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOOS="linux"

This is specifically on Fedora 25, and I also have the standard Fedora 25 version of gccgo installed (gcc-go-6.3.1-1.fc25.x86_64), which is potentially relevant since this failure involves running gccgo.

What did you do?

Attempting to build Go from the current version now fails at TestIssue7573:

ok      cmd/fix 0.014s
--- FAIL: TestIssue7573 (0.07s)
        go_test.go:310: running testgo [build -n -compiler gccgo cgoref]
        go_test.go:323: standard error:
        go_test.go:324: 
                #
                # cgoref
                #

                mkdir -p $WORK/cgoref/_obj/
                mkdir -p $WORK/cgoref/_obj/exe/
                cd /tmpfs/gotest308808976/src/cgoref
                CGO_LDFLAGS="-g" "-O2" "-L" "/tmpfs/gotest308808976/src/cgoref/alibpath" "-lalib" /tmp/go/pkg/tool/linux_amd64/cgo -objdir $WORK/cgoref/_obj/ -importpath cgoref -gccgo -- -I $WORK/cgoref/_obj/ -g -O2 -fsplit-stack cgoref.go
                cd $WORK/cgoref/_obj
                gcc -I /tmpfs/gotest308808976/src/cgoref -fPIC -m64 -pthread -fmessage-length=0 -I ./ -g -O2 -fsplit-stack -o /tmpfs/gotest308808976/src/cgoref/$WORK/cgoref/_obj/_cgo_export.o -c _cgo_export.c
                gcc -I /tmpfs/gotest308808976/src/cgoref -fPIC -m64 -pthread -fmessage-length=0 -I ./ -g -O2 -fsplit-stack -o /tmpfs/gotest308808976/src/cgoref/$WORK/cgoref/_obj/cgoref.cgo2.o -c cgoref.cgo2.c
                cd /tmpfs/gotest308808976/src/cgoref
                gcc -Wall -g -I $WORK/cgoref/_obj/ -I /tmp/go/pkg/include -o $WORK/cgoref/_obj/_cgo_defun.o -D GOOS_linux -D GOARCH_amd64 -m64 -fsplit-stack -c $WORK/cgoref/_obj/_cgo_defun.c
                /usr/bin/gccgo -I $WORK -c -g -m64 -fgo-relative-import-path=_/tmpfs/gotest308808976/src/cgoref -o $WORK/cgoref/_obj/_go_.o $WORK/cgoref/_obj/_cgo_gotypes.go $WORK/cgoref/_obj/cgoref.cgo1.go
                ar rc $WORK/libcgoref.a $WORK/cgoref/_obj/_go_.o $WORK/cgoref/_obj/_cgo_flags $WORK/cgoref/_obj/_cgo_export.o $WORK/cgoref/_obj/cgoref.cgo2.o $WORK/cgoref/_obj/_cgo_defun.o
                cd .
                /usr/bin/gccgo -o $WORK/cgoref/_obj/exe/a.out $WORK/cgoref/_obj/_go_.o $WORK/cgoref/_obj/_cgo_export.o $WORK/cgoref/_obj/cgoref.cgo2.o $WORK/cgoref/_obj/_cgo_defun.o -Wl,-( -m64 -Wl,--whole-archive -Wl,--no-whole-archive -L /tmpfs/gotest308808976/src/cgoref/alibpath -lalib -Wl,-) -Wl,-E
                mv $WORK/cgoref/_obj/exe/a.out cgoref

        go_test.go:409: no Go-inline "#cgo LDFLAGS:" ("-L alibpath -lalib") passed to gccgo linking stage
        go_test.go:410: pattern gccgo.*\-L alibpath \-lalib not found in standard error
FAIL
FAIL    cmd/go  34.788s

This appears to be because the pattern no longer matches the actual -L line, because something sticks the test directory into the '-L alibpath' bit. I believe this is the result of commit b488073, which was intended to fix issue #20266. Certainly this commit is the point where I start getting this FAIL, while Go builds fine at d1211b9.
@ianlancetaylor ianlancetaylor self-assigned this Jun 13, 2017
@ianlancetaylor ianlancetaylor added this to the Go1.9 milestone Jun 13, 2017
@gopherbot
Copy link

CL https://golang.org/cl/45650 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@siebenmann @ianlancetaylor @gopherbot