Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: make gopherbot leave review comments on Gerrit for common mistakes #20648

Closed
mdlayher opened this issue Jun 12, 2017 · 5 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mdlayher
Copy link
Member

A common mistake when adding a new Go source file to the Go project is to omit the license header.

This means that a human has to point out the mistake every time, and for each file.

I think it makes sense to have the trybots do this instead. It'll save a bit of time and effort for reviewers, and help catch an easy mistake earlier in the review process for the author of the CL.

Thoughts?

/cc @bradfitz

@mdlayher mdlayher added the Builders x/build issues (builders, bots, dashboards) label Jun 12, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jun 12, 2017
@ianlancetaylor
Copy link
Contributor

This might be a better fit for the codereview plugin, which I believe already has a check that all Go files are gofmt-compliant.

@mdlayher
Copy link
Member Author

That would be fine with me as well. I suppose I haven't ever run into that check since my editor takes care of formatting for me.

Either way, I think some automation could be very helpful.

@bradfitz
Copy link
Contributor

@ianlancetaylor, once we accept Github PRs, it's no longer a good assumption that all users use git-codereview. We want to build something like Google's Tricorder where bots leave comments on the CLs (in Gerrit) instead, so it doesn't matter which tool they used to send a change.

@bradfitz
Copy link
Contributor

@andybons, this bug is about doing a Tricorder-style thing for Go, where gopherbot looks at pending CLs and runs plugins and drops review comments in Gerrit.

Start of work for it is in pending CL https://go-review.googlesource.com/c/build/+/38285

@bradfitz bradfitz changed the title x/build: trybots should check all source files for license header x/build: make gopherbot leave review comments on Gerrit for common mistakes Dec 15, 2017
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Dec 15, 2017
@bradfitz
Copy link
Contributor

Dup of #18548

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants