Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/printer: CommentedNode cannot print associated comments if it has a leading comment #20635

Closed
hirochachacha opened this issue Jun 9, 2017 · 1 comment

Comments

@hirochachacha
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

package main

import (
	"go/parser"
	"go/printer"
	"go/token"
	"os"
)

const input = `package main

// leading comment
type x int // comment2

`

func main() {
	fset := token.NewFileSet()
	f, err := parser.ParseFile(fset, "input.go", input, parser.ParseComments)
	if err != nil {
		panic(err)
	}
	printer.Fprint(os.Stdout, fset, f.Decls[0])
	printer.Fprint(os.Stdout, fset, &printer.CommentedNode{Node: f.Decls[0], Comments: f.Comments})
}

What did you expect to see?

// leading comment
type x int	// comment2
// leading comment
type x int	// comment2

What did you see instead?

// leading comment
type x int	// comment2
// leading comment
type x int

Does this issue reproduce with the latest release (go1.8.3)?

yes.

System details

go version devel +760636d55a Thu Jun 8 23:54:27 2017 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hiro/.go"
GORACE=""
GOROOT="/Users/hiro/go"
GOTOOLDIR="/Users/hiro/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wq/dwn8hs0x7njbzty9f68y61700000gn/T/go-build669466350=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +760636d55a Thu Jun 8 23:54:27 2017 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +760636d55a Thu Jun 8 23:54:27 2017 +0000 X:framepointer
uname -v: Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.12.5
BuildVersion:	16F73
lldb --version: lldb-370.0.42
  Swift-3.1
gdb --version: GNU gdb (GDB) 7.12.1
@gopherbot
Copy link

CL https://golang.org/cl/45292 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants