Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: golang.org/cl/44956 regresses lxd tests #20631

Closed
mwhudson opened this issue Jun 9, 2017 · 5 comments
Closed

database/sql: golang.org/cl/44956 regresses lxd tests #20631

mwhudson opened this issue Jun 9, 2017 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.9

Comments

@mwhudson
Copy link
Contributor

mwhudson commented Jun 9, 2017 •
edited

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

$ go version
go version devel +b7c51c5 Wed Jun 7 21:00:42 2017 +0000 linux/amd64

What operating system and processor architecture are you using (go env)?

linux/amd64

What did you do?

$ go get github.com/lxc/lxd/lxd
$ go test -c github.com/lxc/lxd/lxd
$ for i in `seq 10`; do ./lxd.test; done

What did you expect to see?

PASS

What did you see instead?

Failures like this:

--- FAIL: TestContainer_IsPrivileged_Privileged (0.00s)
        Error Trace:    container_test.go:198
	Error:      	Expected nil, but got: &errors.errorString{s:"No such object"}
--- FAIL: TestContainer_findIdmap_mixed (0.02s)
        Error Trace:    container_test.go:293
	Error:      	Expected nil, but got: sqlite3.Error{Code:9, ExtendedCode:9, err:"interrupted"}
--- FAIL: TestContainerTestSuite (7.48s)

(it's not completely consistent, rarely it passes, sometimes details differ).

Bisect fingered ef0f7fb
@bradfitz
Copy link
Contributor

bradfitz commented Jun 9, 2017

Like what?

/cc @kardianos

@bradfitz bradfitz added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 9, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Jun 9, 2017
@mwhudson
Copy link
Contributor Author

mwhudson commented Jun 9, 2017

Like I clicked submit too soon, updated now.

@bradfitz
Copy link
Contributor

bradfitz commented Jun 9, 2017

https://golang.org/cl/44956 is ef0f7fb ("database/sql: Use Tx.ctx in Tx non-context methods")

@gopherbot
Copy link

CL https://golang.org/cl/45231 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 12, 2017
@kardianos @bradfitz
Revert "database/sql: Use Tx.ctx in Tx non-context methods"
3820191 
This reverts commit ef0f7fb.

Reason for revert: Altered behavior of Queries prior to Tx commit. See #20631.

Change-Id: I2548507c2935a7c60b92aae377dcc8e9aca66331
Reviewed-on: https://go-review.googlesource.com/45231
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
Reviewed-by: Bulat Gaifullin <gaifullinbf@gmail.com>
Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@mwhudson
Copy link
Contributor Author

mwhudson commented Jun 13, 2017 •
edited

Fixed by the revert.

@golang golang locked and limited conversation to collaborators Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
3 participants
@bradfitz @mwhudson @gopherbot