Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: spurious error in TestPanicRace #20594

Closed
randall77 opened this issue Jun 6, 2017 · 1 comment
Closed

runtime: spurious error in TestPanicRace #20594

randall77 opened this issue Jun 6, 2017 · 1 comment
Labels
FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.9

Comments

@randall77
Copy link
Contributor

Saw on the trybots for CL 45018:

--- FAIL: TestPanicRace (0.00s)
crash_test.go:584: program exited successfully, should have failed
crash_test.go:587:
crash_test.go:596: did not find expected string "panic: crash"
crash_test.go:596: did not find expected string "PanicRace"
crash_test.go:596: did not find expected string "created by "

I don't think this has anything to do with my CL, it only does additional compile-time checks, and those checks are not enabled on this builder. Flaky test?

https://storage.googleapis.com/go-build-log/6c7e4f31/linux-amd64_b2988fea.log
@randall77 randall77 added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 6, 2017
@randall77 randall77 added this to the Go1.9 milestone Jun 6, 2017
@gopherbot
Copy link

CL https://golang.org/cl/45020 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
4 participants
@bradfitz @ianlancetaylor @randall77 @gopherbot