Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: change trybot success message #20585

Closed
bradfitz opened this issue Jun 5, 2017 · 5 comments
Closed

x/build: change trybot success message #20585

bradfitz opened this issue Jun 5, 2017 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jun 5, 2017

Trybots used to say they were happy on Gerrit with just:

TryBots are happy.

But now it says:

TryBots are happy.
Benchmark results for linux-amd64 are available at:
https://perf.golang.org/search?q=cl:44870+try:Tcacc944a2

That almost implies that Trybots only ran on linux-amd64. (In reality, it was only benchmarks that just ran on linux-amd64).

If we're not going to be concise anymore, we should perhaps just make the message also include all the trybot builders which passed.
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jun 5, 2017
@bradfitz bradfitz self-assigned this Jun 5, 2017
@gopherbot gopherbot added this to the Unreleased milestone Jun 5, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 5, 2017
@josharian
Copy link
Contributor

Suggest: s/for linux-amd64//. The benchmarks page can give the details about platform. And hopefully someday there'll be more.

@Kinghack
Copy link
Contributor

Kinghack commented Jun 13, 2017 •
edited

Maybe it is a good start for contributing by change text message like this?
Could I?

@josharian
Copy link
Contributor

Yes, simple changes like this are a good way to get started. Go for it.

@gopherbot
Copy link

CL https://golang.org/cl/45710 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/45712 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @josharian @Kinghack @gopherbot