Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: mask highest bit of X25519 public key #20582

Closed
aead opened this issue Jun 5, 2017 · 1 comment
Closed

crypto/tls: mask highest bit of X25519 public key #20582

aead opened this issue Jun 5, 2017 · 1 comment
Labels
FrozenDueToAge

Comments

@aead
Copy link
Contributor

aead commented Jun 5, 2017

What version of Go are you using (go version)?

go version go1.8.3 linux/amd64

X25519 implementations should mask the highest bit of the public key. The public key is an element of GF(2^255-19) but is encoded into a 32 byte array/slice - so the highest bit ( publicKey[31] & 0x80 ) is always zero. RFC 7748 specifies that this bit MUST be masked.
@gopherbot
Copy link

CL https://golang.org/cl/44712 mentions this issue.

@aead aead closed this as completed Jun 5, 2017
@golang golang locked and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @aead