Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: restore performance benchmarking dashboard #20552

Open
ianlancetaylor opened this issue Jun 2, 2017 · 7 comments
Open

x/build: restore performance benchmarking dashboard #20552

ianlancetaylor opened this issue Jun 2, 2017 · 7 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ianlancetaylor
Copy link
Contributor

In a trybot run in https://storage.googleapis.com/go-build-log/dd2f2f0c/linux-amd64_19b3a9d1.log , after the build and the tests are complete, I see this:

##### 
iteration: 0
start-time: 2017-06-02T00:53:45Z
building testgo failed: exit status 1
can't load package: package .: no buildable Go source files in /tmp/workdir/go-parent

Error: tests failed: dist test failed: bench:bench-cmd-go.exe -test.bench . -test.benchmem -test.run ^$ -test.benchtime 100ms: exit status 2
@ianlancetaylor ianlancetaylor added this to the Go1.9 milestone Jun 2, 2017
@ianlancetaylor
Copy link
Contributor Author

Another trybot run: https://storage.googleapis.com/go-build-log/f7eb06b6/linux-amd64_26eecad0.log

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 5, 2017
@bradfitz
Copy link
Contributor

bradfitz commented Jun 5, 2017

@quentinmit, this looks like the new benchmarks-on-trybot code having problems in some cases. Can you take a look?

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Jun 5, 2017
@bradfitz
Copy link
Contributor

Another:
https://storage.googleapis.com/go-build-log/12c54536/linux-amd64_c57e3046.log
From:
https://go-review.googlesource.com/c/46030/

@quentinmit ?

@bradfitz
Copy link
Contributor

"use of internal package not allowed"
https://storage.googleapis.com/go-build-log/8a70806e/linux-amd64_ca9bc8f3.log

@bradfitz
Copy link
Contributor

Trybot benchmarking was disabled, as announced on golang-dev, so pushing this to Go 1.10.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jun 28, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Unreleased Nov 28, 2017
@bradfitz bradfitz changed the title build: test flake running benchmarks x/build: restore performance benchmarking dashboard Nov 28, 2017
This was referenced May 21, 2018
Closed
Closed
Open
@ysmolski
Copy link
Member

Part of the problem is that I cannot not figure out how to run trybots, etc builder services locally to tinker with it and being able to see results. In case of Playground I could run the whole thing in a docker.

@bradfitz, How does contributors to x/build run trybots locally?

@bradfitz
Copy link
Contributor

@ysmolsky, unfortunately the build system is not easy to hack on locally. It's possible, but pretty tedious and you need to be pretty aware of how it all works. Often times we do most of our testing in our dev+staging GCP project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @quentinmit @ysmolski @ianlancetaylor