Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: outdated reference to ../gc/reflect.c in comments #20525

Closed
dmitris opened this issue May 29, 2017 · 2 comments
Closed

cmd/link: outdated reference to ../gc/reflect.c in comments #20525

dmitris opened this issue May 29, 2017 · 2 comments
Labels
FrozenDueToAge

Comments

@dmitris
Copy link
Contributor

dmitris commented May 29, 2017

https://github.com/golang/go/blob/master/src/cmd/link/internal/ld/decodesym.go#L15-L17 contains references to gc/reflect.c which must be leftovers from the C compiler:

// Decoding the type.* symbols.	 This has to be in sync with
// ../../runtime/type.go, or more specifically, with what
// ../gc/reflect.c stuffs in these.

@rsc - should it be changed to more specifically, with what ../../../compile/internal/gc/reflect.go stuffs in these, or something else?
@ianlancetaylor
Copy link
Contributor

The correct reference is to replace gc/reflect.c with cmd/compile/internal/gc/reflect.go.

@gopherbot
Copy link

CL https://golang.org/cl/44376 mentions this issue.

@golang golang locked and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmitris @ianlancetaylor @gopherbot