Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: git: argument list too long #20518

Closed
AlekSi opened this issue May 28, 2017 · 2 comments
Closed

x/build/maintner: git: argument list too long #20518

AlekSi opened this issue May 28, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@AlekSi
Copy link
Contributor

AlekSi commented May 28, 2017 

$ maintnerd -config=go -debug
[…]
2017/05/28 15:25:28 gerrit go.googlesource.com/go: git directory exists.
2017/05/28 15:25:28 gerrit go.googlesource.com/go: fixing indexing of 20806 missing commits
2017/05/28 15:25:28 gerrit go.googlesource.com/go: fetching 20806 hashes...
2017/05/28 15:25:29 error fetching 20806 hashes from gerrit project go.googlesource.com/go:
2017/05/28 15:25:29 gerrit go.googlesource.com/go: sync: fork/exec /usr/local/bin/git: argument list too long
2017/05/28 15:25:29 IS TEMP ERROR? *os.PathError fork/exec /usr/local/bin/git: argument list too long
2017/05/28 15:25:29 Temporary error from gerrit go.googlesource.com/go: fork/exec /usr/local/bin/git: argument list too long

I hacked code a little to add logging and found that git fetch is really called with 20k hashes:

fetch --quiet origin b3f1dfd7e02b0685f87572d536742300140ed8ee 634af4c052f9570ce59a377bf83b760b28a1d33d […]

I guess syncMissingCommits should use batches too. Maybe batching should be moved from syncOnce to fetchHashes.
@gopherbot gopherbot added this to the Unreleased milestone May 28, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 28, 2017
@AlekSi
Copy link
Contributor Author

AlekSi commented Feb 19, 2018

I don't think this is a problem anymore. @bradfitz please correct me if I'm wrong.

@AlekSi AlekSi closed this as completed Feb 19, 2018
@bradfitz
Copy link
Contributor

@AlekSi, I don't remember fixing this, so I'm not sure. But I also never this problem, and 2-3 other people setup maintner for their projects and didn't report hitting this, so maybe it got fixed.

@golang golang locked and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @AlekSi @gopherbot