Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/asm: Unexpected encoding test of ARM assembler #20465

Closed
benshi001 opened this issue May 23, 2017 · 1 comment
Closed

cmd/asm: Unexpected encoding test of ARM assembler #20465

benshi001 opened this issue May 23, 2017 · 1 comment

Comments

@benshi001
Copy link
Member

In asm/internal/asm/endtoend_test.go

func TestARMEndToEnd(t *testing.T) {
defer os.Setenv("GOARM", os.Getenv("GOARM"))

for _, goarm := range []string{"5", "6", "7"} {
	os.Setenv("GOARM", goarm)
	t.Logf("GOARM=%v", os.Getenv("GOARM"))
	testEndToEnd(t, "arm", "arm")
}

}

It expects to do ARM encoding test for ARMv5, ARMv6, and ARMv7. But actually all 3 tests are done with GOARM=5, and all instructions are encoded for ARMv5, with "GOROOT_BOOTSTRAP=/opt/go1.6 ./all.bash".

I have to do "GOROOT_BOOTSTRAP=/opt/go1.6 GOARM=6 ./all.bash" to test ARMv6 encoding.

@gopherbot
Copy link

CL https://golang.org/cl/43930 mentions this issue.

@golang golang locked and limited conversation to collaborators May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants