net/http/httputil: ReverseProxy does not pass unannounced trailers #20437
Labels
Milestone
Comments
|
CL https://golang.org/cl/43712 mentions this issue. |
|
With the above patch, both helloworld and routeguide grpc-go example will work via httputil.ReverseProxy |
|
I think this might be a breaking change and that's the behavior for any handler/handlefunc I defer to @bradfitz for his view. |
|
The runtime has explicit support for unannounced trailers (marking the headers with the http.TraolerPrefix prefix. It would seem odd if it were expected behaviour for tReversdProxy to drop them. Perhaps I'm missing your point? |
bradfitz
added
the
NeedsFix
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jun 14, 2017
This patch enables HTTP/2 upstream connections. With go1.9 this should also fix gRPC connections See golang/go#20437 Fixes #244
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jun 14, 2017
This patch enables HTTP/2 upstream connections. With go1.9 this should also fix gRPC connections See golang/go#20437 Fixes #244
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Jun 15, 2017
This patch enables HTTP/2 upstream connections. With go1.9 this should also fix gRPC connections See golang/go#20437 Fixes #244
magiconair
added a commit
to fabiolb/fabio
that referenced
this issue
Feb 7, 2018
This patch enables HTTP/2 upstream connections. With go1.9 this should also fix gRPC connections See golang/go#20437 Fixes #244
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?go version devel +2d20ded584 Sat May 20 00:45:56 2017 +0000 linux/amd64
What operating system and processor architecture are you using (
go env)?GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tristan/src/go"
GORACE=""
GOROOT="/home/tristan/src/go"
GOTOOLDIR="/home/tristan/src/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build356611585=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
What did you do?
Attempt to use grpc-go via a httputil.ReverseProxy. grpc.Server does not pre-anounce its trailers. ReverseProxy only passes on pre-anounced trailers.
https://play.golang.org/p/Lt7QPq9vmX
What did you expect to see?
All trailers from upstream should be passed on
What did you see instead?
Only trailers set in the Trailer header are passed on
The text was updated successfully, but these errors were encountered: