Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/talks: build broken for !go1.9 after State of Go May 2017 #20424

Closed
dmitshur opened this issue May 19, 2017 · 2 comments
Closed

x/talks: build broken for !go1.9 after State of Go May 2017 #20424

dmitshur opened this issue May 19, 2017 · 2 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

From https://build.golang.org:

image

Failure log https://build.golang.org/log/e0fa8145c435f6e239bcc0860c34f72f545a9a5a:

linux-amd64 at 753452fac6f6963b5a6e38a239b05362385a3842 building talks at f9d0f43e81708bef917a5084443cfc9c5eade034

../../gopath/src/golang.org/x/talks/2017/state-of-go-may/bits/main.go:5:2: cannot find package "math/bits" in any of:
	/tmp/workdir/go/src/math/bits (from $GOROOT)
	/tmp/workdir/gopath/src/math/bits (from $GOPATH)

tests failed: exit status 1

We can use // +build go1.9 build constraints to fix it.

@campoy Mind sending a fix for this? I'm happy to review a CL. This is similar to #19154.

/cc @bradfitz FYI. This is +1 to having trybots test subrepos with 2 stable Go releases in addition to tip.

@gopherbot gopherbot added this to the Unreleased milestone May 19, 2017
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 19, 2017
@dmitshur dmitshur assigned dmitshur and unassigned campoy May 19, 2017
@bradfitz
Copy link
Contributor

I need to fix #17626

@gopherbot
Copy link

CL https://golang.org/cl/43731 mentions this issue.

@golang golang locked and limited conversation to collaborators May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants