Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: more logs when something goes wrong #20419

Closed
josharian opened this issue May 19, 2017 · 6 comments
Closed

x/build: more logs when something goes wrong #20419

josharian opened this issue May 19, 2017 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

https://build.golang.org/log/16f4dca098af2d81699f154757b5f6b77ada1d3f

Occurred at CL 40095, which definitely touched a lot of the compiler. Frustratingly, there is no indication in the logs whatsoever what failed, and I don't see anything obviously racy in that CL. Running a bunch of race-enabled builds locally has yet to generate a failure. I'll keep at it.

cc @mdempsky @bradfitz for ideas
@josharian josharian added this to the Go1.9 milestone May 19, 2017
@josharian josharian self-assigned this May 19, 2017
@josharian josharian changed the title cmd/compile: racecompile buildure failure on dashboard cmd/compile: racecompile build failure on dashboard May 19, 2017
@bradfitz
Copy link
Contributor

That looks more like the builder's (my) fault than yours.

Maybe the new RPC just added for #20222 failed but something up the chain didn't handle the temporary error nicely.

In any case, those logs suck. I had assumed an RPC failure would result in a retry, but perhaps that's only for trybots. It should write more debug info the build log on failures, just in case it's not retried.

I wouldn't worry about this.

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label May 19, 2017
@bradfitz bradfitz self-assigned this May 19, 2017
@josharian
Copy link
Contributor Author

OK. I've gotten no failures locally either, so I'm going to switch this to be a builders bug about the logs.

@josharian josharian changed the title cmd/compile: racecompile build failure on dashboard x/build: more logs when something goes wrong May 19, 2017
@josharian
Copy link
Contributor Author

This happened again today, at 495f55d mvdan 19 May 18:11: https://build.golang.org/log/5ca06376c703c8190614928d381ffa7c67346b9e

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/43774/ today might've fixed it.

@josharian
Copy link
Contributor Author

Oh I see—those were both very old commits, pre-dash-c. Thanks!

@bradfitz bradfitz modified the milestones: Unreleased, Go1.9 May 23, 2017
@bradfitz
Copy link
Contributor

I think this is done.

@golang golang locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @josharian @gopherbot