-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: more logs when something goes wrong #20419
Comments
That looks more like the builder's (my) fault than yours. Maybe the new RPC just added for #20222 failed but something up the chain didn't handle the temporary error nicely. In any case, those logs suck. I had assumed an RPC failure would result in a retry, but perhaps that's only for trybots. It should write more debug info the build log on failures, just in case it's not retried. I wouldn't worry about this. |
OK. I've gotten no failures locally either, so I'm going to switch this to be a builders bug about the logs. |
This happened again today, at |
https://go-review.googlesource.com/c/43774/ today might've fixed it. |
Oh I see—those were both very old commits, pre-dash-c. Thanks! |
I think this is done. |
https://build.golang.org/log/16f4dca098af2d81699f154757b5f6b77ada1d3f
Occurred at CL 40095, which definitely touched a lot of the compiler. Frustratingly, there is no indication in the logs whatsoever what failed, and I don't see anything obviously racy in that CL. Running a bunch of race-enabled builds locally has yet to generate a failure. I'll keep at it.
cc @mdempsky @bradfitz for ideas
The text was updated successfully, but these errors were encountered: