-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: most trybots don't run gdb tests; add newer gdb #20382
Comments
linux-amd64 (to pick the first failure there, and the most important) is: https://github.com/golang/build/blob/master/env/linux-x86-std-kube/Dockerfile Which is:
https://packages.debian.org/wheezy/gdb -- 7.4.1 We should upgrade to jessie, the current stable: https://packages.debian.org/jessie/gdb -- 7.7.1 Which would pass: if major < 7 || (major == 7 && minor < 7) {
t.Fatalf("skipping: gdb version %d.%d too old", major, minor)
} /cc @jessfraz |
But whoever does this Jessie upgrade (Jessie?) should make sure that any other Docker images using linux-x86-std-kube as their base still build. |
on it
…On Tue, May 16, 2017 at 10:09 PM, Brad Fitzpatrick ***@***.*** > wrote:
But whoever does this Jessie upgrade (Jessie?) should make sure that any
other Docker images using linux-x86-std-kube as their base still build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20382 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbBdh0wCpbwuWDtAkM6Jiuuo8L97bks5r6gKTgaJpZM4NdALO>
.
--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>
|
CL https://golang.org/cl/43535 mentions this issue. |
Updates golang/go#20382 Change-Id: I87ac8f53278f1624232b3239e61b60cc2ee341ca Reviewed-on: https://go-review.googlesource.com/43535 Reviewed-by: Sarah Adams <shadams@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I've updated the Linux images, so this is done... enough. Windows and FreeBSD are too tricky to be worth it. |
Tried CL https://go-review.googlesource.com/c/42670/ to see whether trybots have gdb on them. It turns out that most of the Linux and BSD trybots have gdb that is too old. gdb test is only run on linux-arm trybot. This may make people confusing when the test fails, where people may think the failure is specific to ARM. I think we should run gdb tests on most, if not all, Linux and BSD builders.
The text was updated successfully, but these errors were encountered: