Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime, syscall: Plan 9 ARM assembly code should use "SWI $0" instead of "SWI 0" #20378

Closed
cherrymui opened this issue May 16, 2017 · 3 comments
Closed

runtime, syscall: Plan 9 ARM assembly code should use "SWI $0" instead of "SWI 0" #20378

cherrymui opened this issue May 16, 2017 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@cherrymui
Copy link
Member

On other systems it is all written as SWI $const. We should do the same on Plan 9.
Found by CL https://go-review.googlesource.com/c/43552/.

Leave for Go 1.10.
@cherrymui cherrymui added this to the Go1.10 milestone May 16, 2017
@cherrymui cherrymui self-assigned this May 16, 2017
@gopherbot
Copy link

CL https://golang.org/cl/43533 mentions this issue.

@bradfitz
Copy link
Contributor

I think this is safe enough to fix for Go 1.9, especially if it unblocks that other CL (assuming people want it in for Go 1.9). Your call.

@cherrymui
Copy link
Member Author

Changed the CL targeting Go 1.9.

@golang golang locked and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
3 participants
@bradfitz @gopherbot @cherrymui