Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: dup2 syscall is missing on mips64* #20340

Closed
jcowgill opened this issue May 12, 2017 · 5 comments
Closed

x/sys/unix: dup2 syscall is missing on mips64* #20340

jcowgill opened this issue May 12, 2017 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@jcowgill
Copy link
Contributor

What version of Go are you using (go version)?

go version go1.8.1 linux/mips64le

What operating system and processor architecture are you using?

Debian Stretch mips64el

What did you do?

Run x/sys/unix testsuite.

What did you expect to see?

It passes

What did you see instead?

# golang.org/x/sys/unix_test
./syscall_unix_test.go:326: undefined: unix.Dup2
FAIL    golang.org/x/sys/unix [build failed]

It appears the Dup2 syscall is missing on mips64 and mips64le.
@gopherbot gopherbot added this to the Unreleased milestone May 12, 2017
@gopherbot
Copy link

CL https://golang.org/cl/43430 mentions this issue.

@binarycrusader
Copy link
Contributor

binarycrusader commented May 12, 2017 •
edited

So why is it ok that Dup2 was missing on mips64 and therefore added, but we aren't able to add it for Solaris as seen in #17042?

@jcowgill
Copy link
Contributor Author

Didn't you add it here? golang/sys@68a71b6

@ianlancetaylor
Copy link
Contributor

#17042 was originally opened for the syscall package (the topic line was changed later), and we said that we shouldn't add a new function to the syscall package. This issue is about the x/sys/unix package.

@binarycrusader
Copy link
Contributor

Yes, sorry, I missed that subtlety.

@golang golang locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@binarycrusader @jcowgill @ianlancetaylor @gopherbot