New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: x/tools/present: add support to mark text as inserted (+) or deleted (~) to the present package #20283
Comments
I'm pushing back on changes like this, to try to keep present's syntax from becoming intricate and requiring special work to step around when necessary. Is this one worth fighting for? I've never wanted anything like it, but maybe that's just me. |
Whether this one is worth fighting for depends on the intent or use of the My idea for these changes was to improve the |
FWIW, I've used present occasionally, and it's just about right for straight-forward slide presentation - it's original goal (see its name). Every once in a while I wanted more, but usually then it's a lot more. In those cases I use a different tool. It seems to me that for blog posts eventually one will want a lot more and that one should perhaps use a different tool instead. |
@griesemer Thanks for your comment. Care to share which tools you used? |
@afh I'm pretty happy with Google Slides for those presentations where I need a bit more flexibility. |
I hesitate to mention this, because we're not ready to do anything about it today or in the near term, but in the longer term it seems like Markdown has won and we should plan to move away from our custom markup to Markdown. So I'd suggest for now treating present syntax as basically frozen. |
Agree with @rsc. Present is convenient, but doesn't really offer any
significant benefits over markdown. I regret not translating all our stuff
to markdown years ago.
|
Markdown would be fine with me if someone else were to do all the conversions. However, a major caveat: we cannot lose the functionality of .play. But it should be easy to preserve it as an extension. |
We're not the only users of present, and I suspect other users may want their presentations to work in the future. I think it's fine to introduce markdown, but the old format should still be accepted (and perhaps internally translated to markdown) by present. |
Thank you everyone for your comments, quite insightful. What I hear is that if changes to the package are made then
|
That sounds right. I'm going to close this bug as "move to markdown first". |
👍 |
Proposal
Marking text as inserted or deleted (e.g.
deletedinserted) to show corrections in a text can be helpful, especially in blog post articles.I hereby propose to add the following additional text markers to
[present.font])https://github.com/golang/tools/blob/master/present/style.go#L40)
:~
to denote deleted text, which will render the marked text within the<del>
-tag+
to denote inserted text, which will render the marked text within the<ins>
-tagSee Gerrit Change #42818 for details.
What did you do?
Compile and run the following program:
What did you expect to see?
This is <del>deleted</del> <ins>inserted</ins> text.
What did you see instead?
This is ~deleted~ +inserted+ text.
What version of Go are you using (
go version
)?go version go1.8.1 darwin/amd64
What operating system and processor architecture are you using (
go env
)?The text was updated successfully, but these errors were encountered: