cmd/cgo: #include relative to current directory broken since Go 1.8 #20266

gooid · 2017-05-06T08:10:32Z

What version of Go are you using (`go version`)?

go version devel +4b2f7b4 Sat May 6 01:28:38 2017 +0000 windows/amd64

What did you do?

main.go

package main

//#cgo CFLAGS: -Iinc
//#include "foo.h"
import "C"

func main() {
	println(C.FOO)
}

inc\foo.h

#define FOO	5

go build main.go
.\main.go:4:10: fatal error: foo.h: No such file or directory
//#include "foo.h"
^~~~~~~
compilation terminated.

go1.8.1 is ok.

The text was updated successfully, but these errors were encountered:

davecheney · 2017-05-06T08:17:53Z

Put main.go into a package a use go build github.com/you/yourproject To build the package, rather than the file. Explanation: when you involve go build (or run, or text) with a set of file, rather than a package, the source code is compiled in a synthetic package constructed in /tmp, which is why the file foo.h is not found.

…

On Sat, 6 May 2017, 18:10 zan ***@***.***> wrote: Please answer these questions before submitting your issue. Thanks! What version of Go are you using (go version)? go version devel +4b2f7b4 Sat May 6 01:28:38 2017 +0000 windows/amd64 What did you do? main.go `package main //#cgo CFLAGS: -Iinc //#include "foo.h" import "C" func main() { println(C.FOO) } inc\foo.h#define FOO 5 ` go build main.go */d*/GoLang/projects/test/foo .\main.go:4:10: fatal error: foo.h: No such file or directory //#include "foo.h" ^~~~~~~ compilation terminated. go1.8.1 is ok. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20266>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA-uVz3HTrhqO5zTCscOevneVrC72ks5r3Cr5gaJpZM4NSq57> .

bradfitz · 2017-05-06T15:58:44Z

If Go 1.8 is okay and tip is not, though, I want to make sure this was intentional.

/cc @rsc @ianlancetaylor

ianlancetaylor · 2017-05-07T00:44:45Z

Works for me using both Go 1.8 and Go 1.9.

For the failing case please show us the output of go build -x main.go.

alexbrainman · 2017-05-07T01:55:37Z

please show us the output of go build -x main.go.

Fails for me on the tip on both windows-amd64 and linux-amd64:

c:\Users\Alex\dev\src\issues\issue20266>dir
 Volume in drive C has no label.
 Volume Serial Number is F0C8-6DFE

 Directory of c:\Users\Alex\dev\src\issues\issue20266

07/05/2017  11:40 AM    <DIR>          .
07/05/2017  11:40 AM    <DIR>          ..
07/05/2017  11:40 AM    <DIR>          inc
07/05/2017  11:38 AM               105 main.go
               1 File(s)            105 bytes
               3 Dir(s)  82,081,398,784 bytes free

c:\Users\Alex\dev\src\issues\issue20266>type main.go
package main

//#cgo CFLAGS: -Iinc
//#include "foo.h"
import "C"

func main() {
        println(C.FOO)
}
c:\Users\Alex\dev\src\issues\issue20266>type inc\foo.h
#define FOO     5

c:\Users\Alex\dev\src\issues\issue20266>go version
go version devel +5300362 Sun May 7 01:26:02 2017 +0000 windows/amd64

c:\Users\Alex\dev\src\issues\issue20266>go build -x
WORK=C:\Users\Alex\AppData\Local\Temp\go-build643016190
mkdir -p $WORK\issues\issue20266\_obj\
mkdir -p $WORK\issues\issue20266\_obj\exe\
cd c:\users\alex\dev\src\issues\issue20266
CGO_LDFLAGS="-g" "-O2" "c:\\users\\alex\\dev\\go\\pkg\\tool\\windows_amd64\\cgo.exe" -objdir "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\" -importpath issues/issue20266 -- -I "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\" -g -O2 -Iinc main.go
cd $WORK
gcc -fdebug-prefix-map=a=b -c trivial.c
gcc -gno-record-gcc-switches -c trivial.c
cd $WORK\issues\issue20266\_obj
gcc -I "c:\\users\\alex\\dev\\src\\issues\\issue20266" -m64 -mthreads -fmessage-length=0 "-fdebug-prefix-map=C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190=/tmp/go-build" -gno-record-gcc-switches -I "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\" -g -O2 -Iinc -o "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\_cgo_export.o" -c _cgo_export.c
gcc -I "c:\\users\\alex\\dev\\src\\issues\\issue20266" -m64 -mthreads -fmessage-length=0 "-fdebug-prefix-map=C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190=/tmp/go-build" -gno-record-gcc-switches -I "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\" -g -O2 -Iinc -o "C:\\Users\\Alex\\AppData\\Local\\Temp\\go-build643016190\\issues\\issue20266\\_obj\\main.cgo2.o" -c main.cgo2.c
# issues/issue20266
.\main.go:4:17: fatal error: foo.h: No such file or directory
compilation terminated.

c:\Users\Alex\dev\src\issues\issue20266>

Alex

hirochachacha · 2017-05-07T15:01:44Z

It seems that 8ae60dc is the cause.
8ae60dc converts -o relpath to -o abspath.
But it doesn't handle -I relpath and -L relpath well.

ianlancetaylor · 2017-05-08T20:58:57Z

Oh, I see. It should work to write

-I ${SRCDIR}/inc

See https://golang.org/cmd/cgo/ .

I'm not sure whether we have introduced a new bug or whether your code is relying on undocumented behavior. I mean, you are definitely using undocumented behavior, and there is a documented workaround, but if a lot of people do what you are doing then perhaps we shouldn't change it.

See golang/go#20266

davecheney · 2017-05-22T09:34:38Z

What didn't work? Could you show what you tried and what happened what you did, please.

…

On Mon, 22 May 2017, 19:02 Alessandro Arzilli ***@***.***> wrote: you are definitely using undocumented behavior, and there is a documented workaround what's the documented workaround? Using go build pathtopackage, like @davecheney <https://github.com/davecheney> said, doesn't work either, at least not for me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20266 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA7qGniWCvrkliTGr55UYZW4w3mbiks5r8U8vgaJpZM4NSq57> .

aarzilli · 2017-05-22T10:17:30Z

@davecheney never mind, I didn't read all of @ianlancetaylor's message.

rsc · 2017-05-22T20:18:46Z

This worked as recently as Go 1.8. Seems like we should keep it working for Go 1.9.

gopherbot · 2017-05-26T05:21:28Z

CL https://golang.org/cl/44291 mentions this issue.

Updates #20266. Fixes #20664. Change-Id: Ifca30409fc7971497efb6d84f3f98760157c2233 Reviewed-on: https://go-review.googlesource.com/45650 Reviewed-by: Austin Clements <austin@google.com>

bradfitz added this to the Go1.9 milestone May 6, 2017

bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 6, 2017

ianlancetaylor mentioned this issue May 18, 2017

cmd/go, cmd/cgo: cgo includes with dots cause file not to found error #20405

Closed

aarzilli added a commit to aarzilli/golua that referenced this issue May 22, 2017

update to work with go1.9

e711788

See golang/go#20266

aarzilli added a commit to aarzilli/golua that referenced this issue May 22, 2017

update to work with go1.9

8eb37ae

See golang/go#20266

aarzilli added a commit to aarzilli/golua that referenced this issue May 22, 2017

update to work with go1.9

668e6cd

See golang/go#20266

rsc assigned ianlancetaylor May 22, 2017

rsc changed the title ~~cmd/go: gcc include error~~ cmd/cgo: #include relative to current directory broken since Go 1.8 May 22, 2017

rsc added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jun 5, 2017

gopherbot closed this as completed in b488073 Jun 13, 2017

siebenmann mentioned this issue Jun 13, 2017

cmd/go: TestIssue7573 now fails after commit b488073 #20664

Closed

golang locked and limited conversation to collaborators Jun 13, 2018

gopherbot added the FrozenDueToAge label Jun 13, 2018

rsc unassigned ianlancetaylor Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/cgo: #include relative to current directory broken since Go 1.8 #20266

cmd/cgo: #include relative to current directory broken since Go 1.8 #20266

gooid commented May 6, 2017 •

edited

davecheney commented May 6, 2017 via email

bradfitz commented May 6, 2017

ianlancetaylor commented May 7, 2017

alexbrainman commented May 7, 2017

hirochachacha commented May 7, 2017

ianlancetaylor commented May 8, 2017

davecheney commented May 22, 2017 via email

aarzilli commented May 22, 2017

rsc commented May 22, 2017

gopherbot commented May 26, 2017

cmd/cgo: #include relative to current directory broken since Go 1.8 #20266

cmd/cgo: #include relative to current directory broken since Go 1.8 #20266

Comments

gooid commented May 6, 2017 • edited

What version of Go are you using (go version)?

What did you do?

go1.8.1 is ok.

davecheney commented May 6, 2017 via email

bradfitz commented May 6, 2017

ianlancetaylor commented May 7, 2017

alexbrainman commented May 7, 2017

hirochachacha commented May 7, 2017

ianlancetaylor commented May 8, 2017

davecheney commented May 22, 2017 via email

aarzilli commented May 22, 2017

rsc commented May 22, 2017

gopherbot commented May 26, 2017

gooid commented May 6, 2017 •

edited

What version of Go are you using (`go version`)?