Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: stopping X11 application makes it unresponsive #20256

Closed
veger opened this issue May 5, 2017 · 2 comments
Closed

x/mobile: stopping X11 application makes it unresponsive #20256

veger opened this issue May 5, 2017 · 2 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile
Milestone
Unreleased

Comments

@veger
Copy link

veger commented May 5, 2017

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GORACE=""
GOROOT="/usr/lib/go-1.7"
GOTOOLDIR="/usr/lib/go-1.7/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build582626726=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

I started the mobile/basic example using Ubuntu, so the X11 driver is used.
When closing it, the application does not get the StageDead lifecycle event and is not stopped completely.

What did you expect to see?

That the application is properly stopped

What did you see instead?

The paint events stop, making the application unresponsive.
@gopherbot
Copy link

CL https://golang.org/cl/42811 mentions this issue.

@bradfitz bradfitz changed the title Stopping X11 application makes it unresponsive x/mobile: stopping X11 application makes it unresponsive May 5, 2017
@gopherbot gopherbot added this to the Unreleased milestone May 5, 2017
veger added a commit to veger/mobile that referenced this issue May 6, 2017
@veger
Fix hang when (X11) application is closed
28dcc74 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
@veger
Copy link
Author

veger commented Jun 5, 2017

It has been a month since I submitted this issue, and provided a PR to fix it, is there something else I need to be doing in order to get it accepted?

veger added a commit to veger/mobile that referenced this issue Jun 9, 2017
@veger
Fix hang when (X11) application is closed
41a5219 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
@bradfitz bradfitz added the mobile Android, iOS, and x/mobile label Jul 20, 2017
pankona pushed a commit to pankona/mobile that referenced this issue Aug 4, 2017
@veger @pankona
Fix hang when (X11) application is closed
a5d74f0 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
pankona pushed a commit to pankona/mobile that referenced this issue Aug 9, 2017
@veger @pankona
Fix hang when (X11) application is closed
aa66222 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
veger added a commit to veger/mobile that referenced this issue Aug 28, 2018
@veger
app:fix hang when application is closed
c0e1b3c 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
veger added a commit to veger/mobile that referenced this issue Aug 28, 2018
@veger
Fix hang when (X11) application is closed
c819286 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
veger added a commit to veger/mobile that referenced this issue Aug 28, 2018
@veger
app: fix hang when application is closed
fd30dfe 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
veger added a commit to veger/mobile that referenced this issue Aug 28, 2018
@veger
app: fix hang when application is closed
c6c719e 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
veger added a commit to veger/mobile that referenced this issue Aug 28, 2018
@veger
app: fix hang when application is closed
08a3a34 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
@golang golang locked and limited conversation to collaborators Aug 29, 2019
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@veger
app: fix hang when application is closed
d510aae 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
Reviewed-on: https://go-review.googlesource.com/42811
Reviewed-by: Elias Naur <elias.naur@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@veger
app: fix hang when application is closed
1a21c3b 
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
Reviewed-on: https://go-review.googlesource.com/42811
Reviewed-by: Elias Naur <elias.naur@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @veger @gopherbot