You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@josharian FWIW, you wrote the old test when you fixed #16902... :-)
I don't believe there's anything wrong here: go/types.Sizes.Sizeof is supposed to be called with a typed value; so in this case the test is simply wrong/not applicable.
Trying a large shift count (0 >> 1080) after disabling the assertion (or removing the explicit calls to Sizeof) leads to the error
invalid operation: invalid shift count 1080 (untyped int constant)
which is perhaps not great, but ok: we don't support shift counts over a certain size.
The following test, which is identical to TestIssue16902 aside from
src
, fails.Result:
The relevant assertion is near the beginning of
StdSizes.SizeOf
:When fixed, we should also test larger shifts, like
0>>1090
, which currently produce a different error.@griesemer
Found by go-fuzz.
The text was updated successfully, but these errors were encountered: