x/build/maintner: inconsistent/not idiomatic spelling of GitHub in two identifiers #20236
Closed
2 tasks done
Labels
Milestone
This is a minor issue. It's also trivial to fix if a minor breaking API change is acceptable (IIRC x/build API is not yet stable, please correct if wrong). It's easier to resolve this sooner rather than later, before it has more users.
Most of the identifiers use "GitHub" or "github" (unexported version) spelling, which is correct and consistent:
type GitHub
type GitHubUser
type GitHubIssue
type GitHubLabel
type GitHubMilestone
type GitHubComment
type GitHubIssueEvent
type GitHubIssueRef
But 2 identifiers use "Github", which is neither:
type GithubRepoID
func (*Corpus) TrackGithub
They should be renamed to use "GitHub", if possible.
Rationale: https://dmitri.shuralyov.com/idiomatic-go#for-brands-or-words-with-more-than-1-capital-letter-lowercase-all-letters.
References: https://github.com/logos, https://en.wikipedia.org/wiki/GitHub.
/cc @bradfitz
The text was updated successfully, but these errors were encountered: