Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: ensure releaseConn is defined before a possible close (cherry-pick to Go 1.8) #20217

Closed
freedombird9 opened this issue May 3, 2017 · 10 comments
Closed

database/sql: ensure releaseConn is defined before a possible close (cherry-pick to Go 1.8) #20217

freedombird9 opened this issue May 3, 2017 · 10 comments
Labels
FrozenDueToAge
Milestone
Go1.8.3

Comments

@freedombird9
Copy link

@kardianos Hi, I wonder when Commit 2133d63 is planned to be merged to release 1.8? I'm also experiencing this issue in many of our programs due to a recent upgrade to Go 1.8.1. Thanks.
@ALTree
Copy link
Member

ALTree commented May 3, 2017 •
edited
Loading

when Commit 2133d63 is planned to be merged to release 1.8?

I see no indication on the CL, in the issue it fixes or in the github milestone that the patch is being considered for inclusion in go1.8.2.

Are you requesting the inclusion of the patch in go1.8.2?

@bradfitz
Copy link
Contributor

bradfitz commented May 3, 2017

@kardianos, is this something that qualifies for a minor release cherrypick?

@bradfitz bradfitz changed the title Commit 2133d63 Merge to Release database/sql: cherry-pick CL 42139 to Go 1.8 branch? May 3, 2017
@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 3, 2017
@kardianos
Copy link
Contributor

This is not a security issue. It may cause a panic.

Regardless, in the meantime if this affects you, you can vendor database/SQL and database/sql/driver and apply the patch locally.

It is a one line patch.

@bradfitz
Copy link
Contributor

bradfitz commented May 3, 2017

That's a lot of work for a user to do to fix a panic.

Are you comfortable with the patch being backported to 1.8.x? It looks small at least.

@bradfitz bradfitz added this to the Go1.8.2 milestone May 3, 2017
@kardianos
Copy link
Contributor

Yep. It would need to be a new CL. I'll get one ready in case of a 1.8.2.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/42532 mentions this issue.

@freedombird9
Copy link
Author

A coworker once played around with the Go runtime and it's a pain in the ass to compile it, took a long time to figure out how to build it properly.

@kardianos
Copy link
Contributor

@freedombird9 You wouldn't need to compile it, just copy (database/sql and database/sql/driver) in to the vendor folder. But a CL is coming.

@bradfitz
Copy link
Contributor

bradfitz commented May 3, 2017

@freedombird9, you just run "./make.bash" in the "src" directory and wait about 45 seconds. This is all documented at https://golang.org/doc/install/source

@freedombird9
Copy link
Author

Sounds easy enough. You know when it's gonna released to 1.8.2? If soon, I'll probably just wait and won't bother to build a docker image out of it myself.

@kardianos kardianos removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 18, 2017
@bradfitz bradfitz modified the milestones: Go1.8.2, Go1.8.3 May 18, 2017
gopherbot pushed a commit that referenced this issue May 23, 2017
@kardianos @broady
[release-branch.go1.8] database/sql: ensure releaseConn is defined be…
6efa2f2 
…fore a possible close

Applies https://golang.org/cl/42139 to the go1.8 release branch.

Also correct two minor issues detected with go vet.

Fixes #20217

Change-Id: I2c41af9497493598fbcfc140439b4e25b9bb7e72
Reviewed-on: https://go-review.googlesource.com/42532
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
@broady broady closed this as completed May 23, 2017
@bradfitz bradfitz changed the title database/sql: cherry-pick CL 42139 to Go 1.8 branch? database/sql: ensure releaseConn is defined before a possible close (cherry-pick to Go 1.8) May 24, 2017
@golang golang locked and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8.3
Development

No branches or pull requests
6 participants
@bradfitz @broady @kardianos @ALTree @freedombird9 @gopherbot