Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: don't push gitignored files #20197

Closed
josharian opened this issue May 1, 2017 · 2 comments
Closed

x/build/cmd/gomote: don't push gitignored files #20197

josharian opened this issue May 1, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

Broken out from #13834 (comment).

I have a lot of gitignored files in my GOROOT. (Don't ask, please.) gomote pushes them all, which is slow and pointless. I'd like gomote not to do this. I would implement by starting a git check-ignore process running concurrently and feeding it paths as part of the filepath walk.

This issue is to ask for approval before putting in the time to implement.

@bradfitz
@josharian josharian added this to the Unreleased milestone May 1, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 1, 2017
@bradfitz
Copy link
Contributor

bradfitz commented May 1, 2017

Sure.

@gopherbot
Copy link

CL https://golang.org/cl/42252 mentions this issue.

kevinburke pushed a commit to kevinburke/build that referenced this issue May 2, 2017
@josharian @kevinburke
cmd/gomote: don't push gitignored files
e960acc 
Fixes golang/go#20197
Updates golang/go#13834

Change-Id: Ib87b174f8aabfc6b8c802ee930813238f330d218
Reviewed-on: https://go-review.googlesource.com/42252
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @josharian @gopherbot