Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: zeroAuto clobbers flags on s390x #20187

Closed
mundaym opened this issue Apr 30, 2017 · 1 comment
Closed

cmd/compile: zeroAuto clobbers flags on s390x #20187

mundaym opened this issue Apr 30, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mundaym
Copy link
Member

mundaym commented Apr 30, 2017

As discussed in CL 41076: zeroAuto is called after register allocation etc. and the flags (condition code) may be live. The current implementation of zeroAuto on s390x clobbers flags so it needs to be modified.

My plan is to modify the assembler to not clobber flags when assembling MOVD $0, <auto> (currently it might use the AGFI instruction) and change zeroAuto to use that.

@mundaym mundaym added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 30, 2017
@mundaym mundaym added this to the Go1.9 milestone Apr 30, 2017
@mundaym mundaym self-assigned this Apr 30, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/42179 mentions this issue.

@golang golang locked and limited conversation to collaborators May 2, 2018
@rsc rsc unassigned mundaym Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants